From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id BAB64A0A02;
Tue, 18 May 2021 14:46:31 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A12F04068E;
Tue, 18 May 2021 14:46:31 +0200 (CEST)
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com
[64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id B198A40041
for <dev@dpdk.org>; Tue, 18 May 2021 14:46:29 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.west.internal (Postfix) with ESMTP id 04E9E12E7;
Tue, 18 May 2021 08:46:25 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute4.internal (MEProxy); Tue, 18 May 2021 08:46:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
thKjsxCfSlDGanaPLo48P+A3zlLIUQ7lsTmjpI/Z0lU=; b=JPCrNDMM4NQUOsoh
/Gl9w/zWf+6VOanQlyKj/bkJjJgN2e9/lKX0ir4h1Qqaaw6LnTwF0EXQTb1do+hX
Ikv1i/LvmzZ9oHa5vxp5V3ZISP4S9OQ5PYEx8kYFiGaXIw/yoCAhxekblxtdifwj
i12GCuKvTHuLV7Kud/0B5ujNVD/G/fb5eJG0LDWh7vmzo5O8S4wBcqU+olpbJ1eX
yZLO71qqyK9V25/1oBjbb9A0U3a7aB6OUOUNKDebmDGCmmq5qmkUpqnPs1HIqh8I
D+zF3BG8UVDaAHxz2HsWIBnv8ooKuPL1x66NW8NetkyhFyM+H16xa/vCT3VFO/Ga
VjMlRQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=thKjsxCfSlDGanaPLo48P+A3zlLIUQ7lsTmjpI/Z0
lU=; b=kcIqps25bWDqhMdi+s5peZGCqixGGXSzxZYMWtaCbzlYsfkFi91SWYDiL
xXi4kq46zrupud7pBt7z0l1r308KO44ALxRVt4vWxcjfKiMTPVd0Fb78TLYwWcOp
FseK8lNxWFgOnTjhHETKbWvUqgJIZdJ3XOfE1Gme6w9VBLt16m7bPBSEH5aEvz8k
Hx7DA8zQwhNjSia4ojcEalPLClolPFU6uXJ2xgUjR9cSZFDROVlQ192mi3scopAI
Qg/BmHZFKun+xf8dSkZ737wQWLWb3vmel4fMP4DgmLmtsT636jOYZnYLdug5uV8E
/UF+yoH6mHNcdLBsvAJIokekqnEpg==
X-ME-Sender: <xms:ILejYL-w-mlElZby_8E8eLOfwMJph__1KyJde2ATBH1VepoYxQdvgw>
<xme:ILejYHv3kjQFLzU01AuXqgAzCwxzzVjk0V-Z4LhKHP0zSsEP5xTZHHYu1Sw1jGWPP
2aFes61_dEpJ9_8NQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeijedgheehucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:ILejYJA5sDOcz4Rj7eqRqhXV6_K80dLWztGsW-Ulzp7OvGE5dTRz8g>
<xmx:ILejYHdOY4tH062Mqc99qe_B1HdT-Ibe3rBV7hSuS8O0XHNNm7HA6w>
<xmx:ILejYAMXv1WZIWIR24Pgs_LrQ18oAQtMXo6NITIphn1tWbN2p2AnBQ>
<xmx:IbejYKX4lAcWy72Ld_PA_bFf8Sgp12t8KkIwb3gFnNrndrtjf_1QeQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA;
Tue, 18 May 2021 08:46:24 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru
Date: Tue, 18 May 2021 14:46:23 +0200
Message-ID: <1951014.XmTQMvWkNT@thomas>
In-Reply-To: <4f9eadeb-a0eb-4eb1-a443-141a3fb6ae0d@intel.com>
References: <1612458325-13508-1-git-send-email-asafp@nvidia.com>
<20210407223320.2952469-4-thomas@monjalon.net>
<4f9eadeb-a0eb-4eb1-a443-141a3fb6ae0d@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 3/3] devtools: check flow API doc tables
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
13/05/2021 20:40, Ferruh Yigit:
> On 4/7/2021 11:33 PM, Thomas Monjalon wrote:
> > +changed_files()
> > +{
> > + [ -n "$files" ] ||
> > + files=$(git diff-tree --name-only -r $trusted_commit..)
> > + echo "$files"
> > +}
> > +
> > +has_code_change() # <pattern>
> > +{
> > + test -n "$(git log --format='%h' -S"$1" $trusted_commit..)"
> > +}
> > +
> > +has_file_change() # <pattern>
> > +{
> > + changed_files | grep -q "$1"
> > +}
> > +
> > +changed_net_drivers()
> > +{
> > + net_paths='drivers/net/|doc/guides/nics/features/'
> > + [ -n "$drivers" ] ||
> > + drivers=$(changed_files |
> > + sed -rn "s,^($net_paths)([^./]*).*,\2,p")
> > + echo "$drivers"
> > +}
>
> I will not reviewed in details yet, but first observation,
> when 'trusted_commit' argument is used, the drivers list has many duplicated
> entries which makes the output redundant and makes script take too much time.
> Getting only unique list may help on it.
Yes good catch, thanks.