From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA3D5A054F; Wed, 25 May 2022 12:52:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54F6F40146; Wed, 25 May 2022 12:52:20 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 05E05400EF; Wed, 25 May 2022 12:52:18 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A5E3C5C00E0; Wed, 25 May 2022 06:52:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 25 May 2022 06:52:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653475938; x= 1653562338; bh=WT8ljsJIXcsD1JwTex9G/TH2lShghUViG63KTbFrogk=; b=W qjkB7rValIhkOMxy3rkVYsIEf80io2e8dY3sKG2lVmzAnPrV5a/zkcqcZijhGKja kR/VsVZUrA/ZCItv1yPltgsrrbX6CUBVWbn6mV3ahSbWxYmFKL7PRXDY24bfjlxC pjh/tT6Y5hESuDIDcBPeSviPw5/A+8o9KvW8B/3zDZt0U7TqU6HcCsbxmAlQz7En Jip1o86/GYdTI9z7joUEWcdnqT5ig4jV6eGMHLIM8fV6R7pi/v9a8iVJX8o9fcf7 3o11eKOVn6J2R49inqD5qSG0FTgtfoJrdKeHxPmItyKfeaSEPYdTrtpsOVjKan60 pX4ZriBbstvSAZHdhJgNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653475938; x= 1653562338; bh=WT8ljsJIXcsD1JwTex9G/TH2lShghUViG63KTbFrogk=; b=S 6anDoVwBBoghwIyF1RmUHsoJSHsPJqo8of7lgMtrV3DbrtNWBYJc6D9q9Gf2qTuS ytiAVAXdmN8FDV4X/+WXTbxDmqw4C4aqhjlslAeRPJbbHrvE21eHy6rJgVtqQ3rF V0o9CpXiyRbqsknLKJG/67fhDImUldpuGQe6O7R0pkIVSuWQE9CLe+kK0HxX31Ip rzdMjymJa6PPWIzM2F9hz2Vprr3aQvq+IBkubMjmDZi4jPclu8KmZFYXTM526bPQ pLQcvXeihIVacIcMn86S4jqSwUBTLWTcY7JQMzKaK/KTgHn0uqZQxcdZELeJLxm2 htjjaEowz5kZjQK8NINOg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeehgdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 May 2022 06:52:17 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: "dev@dpdk.org" , "stable@dpdk.org" , Matan Azrad , Xiaoyun Li , Yuying Zhang , "Singh, Aman Deep" Subject: Re: [PATCH] app/testpmd: fix use of indirect action after port close Date: Wed, 25 May 2022 12:52:09 +0200 Message-ID: <1951250.ZhSLo9btvA@thomas> In-Reply-To: <707c865e-e50b-63e9-a6b0-c46418fd39ae@intel.com> References: <20220307164821.821406-1-dkozlyuk@nvidia.com> <707c865e-e50b-63e9-a6b0-c46418fd39ae@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/04/2022 07:41, Singh, Aman Deep: > On 4/11/2022 2:01 AM, Dmitry Kozlyuk wrote: > >> From: Dmitry Kozlyuk > >> Sent: Thursday, March 31, 2022 1:57 AM > >> [...] > >>> From: Singh, Aman Deep > >>> Sent: Wednesday, March 30, 2022 5:24 PM > >>> [...] > >>> On 3/7/2022 10:18 PM, Dmitry Kozlyuk wrote: > >>>> When a port was closed, indirect actions could remain > >>>> with their handles no longer valid. > >>>> If a newly attached device was assigned the same ID as the closed > >> port, > >>>> those indirect actions became accessible again. > >>>> Any attempt to use them resulted in an undefined behavior. > >>>> Automatically flush indirect actions when a port is closed. > >>>> > >>>> Fixes: 4b61b8774be9 ("ethdev: introduce indirect flow action") > >>>> Cc: stable@dpdk.org > >>>> > >>>> Signed-off-by: Dmitry Kozlyuk > >>>> Acked-by: Matan Azrad > >>>> --- > >>> From: guides/prog_guide/rte_flow.rst > >>> /"If ``RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP`` is advertised,// > >>> //this means that the PMD can keep at least some indirect actions// > >>> //across device stop and start. > >>> > >>> /Please check, if we are inline with the guidelines given in the > >> section. > >> > >> This patch is related to port closing, not port stopping. > >> Flow API resources are owned by the port, > >> so they cannot be valid when the port is closed and its ethdev removed. > >> TestPMD was keeping indirect action handles contrary to this. > Agreed, at port close these should be flushed. LGTM > > Acked-by: Aman Singh Applied in next-net, thanks.