From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9484FA0562; Fri, 19 Mar 2021 10:29:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EF0D140F6E; Fri, 19 Mar 2021 10:29:14 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id F04B2140F6D for ; Fri, 19 Mar 2021 10:29:12 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 2FE01158E; Fri, 19 Mar 2021 05:29:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 19 Mar 2021 05:29:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= dw81y6rKn6w92FP8ifn4mQkkEyxvxZGlkMu0z7TG36k=; b=1HyGyRR+6UKedx+V Lq+l6lMyewVH4B9+4eqUSUXkcagBXt0evDM9iOrdZhYZZ0pvnv+Ey3nH6KYxepQo CLO2iBI6Em1CBag06dzhlJfkOkzl502XIecwwFRsxz27BhBPWZar06lcnVebREMG wLOMlXq9cdeRth7/dk7moPqbhTsplBRwwKgW2KGWsJjmknpldjsifO5TdCOUMpFz XBC7M/W+CgUcDsKNmu5MUMnsAvDXzdoVjCaffOiLEbzWUZWgE486lzaRrHrjctvx yn4op4SPXA91t4KkT8Wy3PW/PskgApc7vHerQafwOveOffc1qkK4FO/goeyDfBDN EWoPYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=dw81y6rKn6w92FP8ifn4mQkkEyxvxZGlkMu0z7TG3 6k=; b=Y0Zw5GjYUQFzbLSkLULxtRoaHG26s/2md0bzIOyVm0TFdOJrj6RbNDeAK xrUC/IJnwQd9UR3OATZMZIuHwZnFtBTf0mKJkfF1muM8xVJdV6m2JuVsoiwtGND0 QWzxL9oGLHCVpGcDAE/enIrIzXauRjpGubM3YGhdXZemCnJfKLr2EzajmDoAiMKH gXjV4cs7/UC6kuDyCfSmU38yRqRO76ZYer/hJUHnYy1aokhkqCQl4WZV+GcAq0cT VVDWIOMauRumLqfu9sBaiv5fPbGzxLMOuKnJZZWJ3fhKNkdAYMbyCdc2r91DLiCo xGNGH8KiaFE02/R2nyYssobj+0eyw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefkedgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 855BF24005A; Fri, 19 Mar 2021 05:29:08 -0400 (EDT) From: Thomas Monjalon To: "Li, Xiaoyun" Cc: "dev@dpdk.org" , "david.marchand@redhat.com" , "Richardson, Bruce" , "mb@smartsharesystems.com" Date: Fri, 19 Mar 2021 10:29:06 +0100 Message-ID: <1952959.zxGQ7ym4U9@thomas> In-Reply-To: References: <20210309233116.1934666-1-thomas@monjalon.net> <20210312181720.242252-12-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 11/11] app/testpmd: fix usage text X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/03/2021 09:59, Li, Xiaoyun: > The patch looks good to me. But I found one issue. > "--tx-ip=SRC,DST | --tx-udp=PORT " These 2 parameters are missing in the detailed usage text below. > > And out of curiosity, I compared the detailed usage items and lgopts in launch_args_parse() > There are several missing items in the usage text. > "--ports" (I didn't find this in the parse actually, should this be removed from lgopts?) > "--noisy-lkup-num-reads-writes" (This one is misspelled in the usage text as the 2nd " noisy-lkup-num- writes ") > "--no-numa" "--mp-anon" "--enable-scatter" There 3 parameters are missing in usage text. Thanks, I will check each of them.