From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 75C725687 for ; Thu, 29 Sep 2016 18:19:25 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id b130so142113727wmc.0 for ; Thu, 29 Sep 2016 09:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=47CvjsISDk+LN/KkeRea471zRmBtoyBKn3l2NyFklGk=; b=WEvM8ReCDJ/T3PA7izuAwlhOPGsnpkImqI7X6HNVxigdQDdRsJQFVvO4XQIeIHpM0v s3apQ6oZt+LiGsvEkRz50INj5Dk5NktVLQ6shuXjZ10+jVlG6nUCoBoG+BXYERACr3zf mYqO3CvyPDn5TX6a5QpCkWvnB+qKKxVBpItdwQUuQ8BH9XSI6fPG0T1ho8kt/HCuvfkB RHNlSAVvQsjx67Ff5Qch5K2C5Sv5qoX1gG/hR82KytFOQaJ8Waaw1qpexx/HOwTMpEK6 bMK4Qyo7CQqOD3JN/JWjDufKk8mAnlbZ/CMBtDeKNkjwgIpwdc3+fw1XW3uLIQVS3Cu+ eA7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=47CvjsISDk+LN/KkeRea471zRmBtoyBKn3l2NyFklGk=; b=Owe4xqnEzgG33znmzCaThF2gZBeIEOOwufR3zigLZp74YBYHwvz1M/S6wnw2eaIGxU Hs/Vtzu0fHZPMDyNqghU2CPk9v4yZlL+A9ZtNOwkfzZ5s+TehCgyGfAoVBN2iJO7lIAJ 70HGUYtpHfWl/HisFCiGiJ/YF+CxlDEubj0bL1gNbz3cxQTNLLL1b6SJ5FsAOhG0XPDN VWj6ckNXfif2nRCXVC/acCzzkAvhWgXydKllLYqvDSh8ROXkwweAeetF50AvHD3h1icl yyOfJw/PRi04Z6bclrylzpTKUFnLMIngX6zIs/adA5y3+lEO42tlF1BZ9ebyuYhBK0xR cq4A== X-Gm-Message-State: AA6/9RmYNXVksgNxxsnIVp44z6FO11Mpvcgl0HVBfJC6hRl5YMLzNFFLiKbhnp+rkKNxvSDo X-Received: by 10.28.95.134 with SMTP id t128mr13228884wmb.99.1475165965240; Thu, 29 Sep 2016 09:19:25 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id xb6sm14951469wjb.30.2016.09.29.09.19.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Sep 2016 09:19:24 -0700 (PDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: dev@dpdk.org, "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" , azelezniak Date: Thu, 29 Sep 2016 18:19:23 +0200 Message-ID: <1953384.ANuSY1Omf7@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A08E0CA@IRSMSX108.ger.corp.intel.com> References: <1474453204-31516-1-git-send-email-bernard.iremonger@intel.com> <3631809.sFy4WKcCTS@xps13> <8CEF83825BEC744B83065625E567D7C21A08E0CA@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 16:19:25 -0000 2016-09-29 15:16, Iremonger, Bernard: > > 2016-09-29 15:16, Bernard Iremonger: > > > +int > > > +rte_eth_dev_set_vf_vlan_stripq(uint8_t port, uint16_t vf, int on); > > > > Why keeping this function in ethdev? > > This function is using an existing API in the eth_dev_ops structure. > > dev->dev_ops->vlan_strip_queue_set > > The vlan_strip_queue_set API is used by the i40e, ixgbe and mlx5 PMD's. OK but it was not used to control VF from PF. This line: (*dev->dev_ops->vlan_strip_queue_set)(dev, q + vf * queues_per_pool, on); seems Intel specific. Please keep "VF from PF" outside of ethdev for 16.11. > > I think it would be more consistent to have also existing VF functions moving > > from ethdev to rte_pmd_ixgbe.h. > > You cannot remove them, but you can create their ixgbe-specific version and > > announce that the ethdev ones are deprecated. > > There are 5 existing VF functions which are only used by ixgbe PMD at present. > It would make sense to create ixgbe-specific versions, however I think this should be done in a separate patchset. Yes it can be a separate patchset for RC2 of course.