From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A309A052A; Sun, 12 Jul 2020 09:35:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 848701D5ED; Sun, 12 Jul 2020 09:35:35 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id BA3A91D5EB for ; Sun, 12 Jul 2020 09:35:34 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 9D962580556; Sun, 12 Jul 2020 03:35:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 12 Jul 2020 03:35:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 0awtJhSETGEiJVASCrGvm4V9RscDD8BkRYb1WyMK/WQ=; b=jAtVtt2QY3R2l42m 67E4uo42gw0NNKP0MiEMayO3Br5qu4r3gWUxOCejoGogQL+MoTZbCsqCz51GI3G1 OPK4P1gBFPk0Zs3RKPiURrir0YRrBkhmYLODSVs4TzWSTf9Mfut9uMS7Bqw2OMFL KvCxyKFkIubcQrTzDTUqLu8p/nsTsipNkrhfagSQto7TDigZrohloRS2eRXYqaFW /To3v36Eut+BMnu/tCorNhROxsDYwWkr7OtuWh9wGpn4cWAeY1M++kveeKsGo/kD fva5nrf9QDRO73wIWQbngPyYicZUuj31JnQL5Y1+fhdDn/xPGCO7e6uK7Hmb9ux0 dDUyww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=0awtJhSETGEiJVASCrGvm4V9RscDD8BkRYb1WyMK/ WQ=; b=iPtf0U4hKHxQ+35YIj0MBOaYBiQtViwq0BSNuR4k2dLCojwBxCvzkF82/ CDtoNG8eqvlPH7YQ2JlaVG69+/0mbGMEPom12wMgsd9zOssmm66CP06zXsqPgsVt rggPBdZ6FXwCfRF5yDtqUhmfRP6d9m370SUohLKbkD/nwstLmuucX0wDcccPlcIX GXvblDHsL2QJjrwfL3X7k1jeFkHBSQLfQyf9pUTOFrEWpV35lAaxGROEi0jnAly2 Sff1/c6qW0/DXByAGIrLi1A8d7w6S1JQWbn3AO9fZeZbnSUSIeBGJSoqZXg2ESCi t2quFVH6QYuN74oBp2fSFIE2EtnUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvdehgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D16F7328005E; Sun, 12 Jul 2020 03:35:26 -0400 (EDT) From: Thomas Monjalon To: Ivan Dyukov Cc: dev@dpdk.org, v.kuramshin@samsung.com, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com, Stephen Hemminger , bruce.richardson@intel.com, olivier.matz@6wind.com Date: Sun, 12 Jul 2020 09:35:23 +0200 Message-ID: <1954009.Q9tCs6qVOH@thomas> In-Reply-To: <424d7367-e947-0d48-ff6e-879ae3268b27@samsung.com> References: <20200427095737.11082-1-i.dyukov@samsung.com> <1652895.iZPJ0jMcVD@thomas> <424d7367-e947-0d48-ff6e-879ae3268b27@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8 02/24] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/07/2020 20:58, Ivan Dyukov: > 11.07.2020 14:27, Thomas Monjalon =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > 11/07/2020 12:43, Ivan Dyukov: > >> +__rte_experimental > >> +int rte_eth_link_printf(const char *const fmt, > >> + const struct rte_eth_link *eth_link); > >> > > Maybe I missed your reply, > > I still don't understand the need for this function. > > > I used it few times in apps in this patchset. It allows to avoid code=20 > duplication in examples. i.e. declare array, call rte_eth_link_to_str,=20 > call printf. >=20 > It's simple and usefull function. Why not? Why not is not a good justification :) We must avoid adding too much in the API.