From: "Min Hu (Connor)" <humin29@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Cc: <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH v2] net/hns3: add runtime config to set MBX limit time
Date: Fri, 22 Oct 2021 09:41:25 +0800 [thread overview]
Message-ID: <19544847-dd22-f83c-3028-afbb7b6cd1b5@huawei.com> (raw)
In-Reply-To: <e7a96544-9ef4-10a5-d76c-2611dfd13a99@intel.com>
Hi, Ferruh,
V3 has been sent,please check it out, thanks.
在 2021/10/21 21:06, Ferruh Yigit 写道:
> On 10/21/2021 3:22 AM, Min Hu (Connor) wrote:
>> From: Chengchang Tang<tangchengchang@huawei.com>
>>
>> Current, the max waiting time for MBX response is 500ms, but in
>> some scenarios, it is not enough. Since it depends on the response
>> of the kernel mode driver, and its response time is related to the
>> scheduling of the system. In this special scenario, most of the
>> cores are isolated, and only a few cores are used for system
>> scheduling. When a large number of services are started, the
>> scheduling of the system will be very busy, and the reply of the
>> mbx message will time out, which will cause our PMD initialization
>> to fail.
>>
>> This patch add a runtime config to set the max wait time. For the
>> above scenes, users can adjust the waiting time to a suitable value
>> by themselves.
>>
>> Fixes: 463e748964f5 ("net/hns3: support mailbox")
>> Cc:stable@dpdk.org
>>
>> Signed-off-by: Chengchang Tang<tangchengchang@huawei.com>
>> Signed-off-by: Min Hu (Connor)<humin29@huawei.com>
>> ---
>> v2:
>> * add some comment for HNS3_MBX_DEF_TIME_LIMIT_MS.
>> * remove some check for mbx_time_limit.
>> ---
>> drivers/net/hns3/hns3_ethdev.c | 32 ++++++++++++++++++++++++++++++-
>> drivers/net/hns3/hns3_ethdev.h | 3 +++
>> drivers/net/hns3/hns3_ethdev_vf.c | 3 ++-
>> drivers/net/hns3/hns3_mbx.c | 8 +++++---
>> drivers/net/hns3/hns3_mbx.h | 1 +
>> 5 files changed, 42 insertions(+), 5 deletions(-)
>
>
> New devarg need to be documented in the 'doc/guides/nics/hns3.rst',
> in "Runtime Config Options" section.
> .
next prev parent reply other threads:[~2021-10-22 1:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 3:48 [dpdk-dev] [PATCH] " Min Hu (Connor)
2021-09-09 13:20 ` Ferruh Yigit
2021-10-21 2:26 ` Min Hu (Connor)
2021-10-21 2:22 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-10-21 13:06 ` Ferruh Yigit
2021-10-22 1:41 ` Min Hu (Connor) [this message]
2021-10-22 1:38 ` [dpdk-dev] [PATCH v3] " Min Hu (Connor)
2021-10-22 2:13 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19544847-dd22-f83c-3028-afbb7b6cd1b5@huawei.com \
--to=humin29@huawei.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).