From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B04BA0C43; Fri, 22 Oct 2021 03:41:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2990B4068C; Fri, 22 Oct 2021 03:41:28 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 57BC140040 for ; Fri, 22 Oct 2021 03:41:27 +0200 (CEST) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Hb6QV5hlMzbnM8 for ; Fri, 22 Oct 2021 09:36:50 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.15; Fri, 22 Oct 2021 09:41:25 +0800 To: Ferruh Yigit , CC: References: <1630295328-44604-1-git-send-email-humin29@huawei.com> <20211021022229.9680-1-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: <19544847-dd22-f83c-3028-afbb7b6cd1b5@huawei.com> Date: Fri, 22 Oct 2021 09:41:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2] net/hns3: add runtime config to set MBX limit time X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferruh, V3 has been sent,please check it out, thanks. 在 2021/10/21 21:06, Ferruh Yigit 写道: > On 10/21/2021 3:22 AM, Min Hu (Connor) wrote: >> From: Chengchang Tang >> >> Current, the max waiting time for MBX response is 500ms, but in >> some scenarios, it is not enough. Since it depends on the response >> of the kernel mode driver, and its response time is related to the >> scheduling of the system. In this special scenario, most of the >> cores are isolated, and only a few cores are used for system >> scheduling. When a large number of services are started, the >> scheduling of the system will be very busy, and the reply of the >> mbx message will time out, which will cause our PMD initialization >> to fail. >> >> This patch add a runtime config to set the max wait time. For the >> above scenes, users can adjust the waiting time to a suitable value >> by themselves. >> >> Fixes: 463e748964f5 ("net/hns3: support mailbox") >> Cc:stable@dpdk.org >> >> Signed-off-by: Chengchang Tang >> Signed-off-by: Min Hu (Connor) >> --- >> v2: >> * add some comment for HNS3_MBX_DEF_TIME_LIMIT_MS. >> * remove some check for mbx_time_limit. >> --- >>   drivers/net/hns3/hns3_ethdev.c    | 32 ++++++++++++++++++++++++++++++- >>   drivers/net/hns3/hns3_ethdev.h    |  3 +++ >>   drivers/net/hns3/hns3_ethdev_vf.c |  3 ++- >>   drivers/net/hns3/hns3_mbx.c       |  8 +++++--- >>   drivers/net/hns3/hns3_mbx.h       |  1 + >>   5 files changed, 42 insertions(+), 5 deletions(-) > > > New devarg need to be documented in the 'doc/guides/nics/hns3.rst', > in "Runtime Config Options" section. > .