From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, olivier.matz@6wind.com, techboard@dpdk.org
Subject: Re: [PATCH] doc: announce deprecation of cmdline_poll
Date: Fri, 28 Jul 2023 11:44:47 +0200 [thread overview]
Message-ID: <1955982.usQuhbGJ8B@thomas> (raw)
In-Reply-To: <20230626093811.178348f4@hermes.local>
26/06/2023 18:38, Stephen Hemminger:
> On Tue, 14 Mar 2023 10:18:58 -0700
> Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> > Function was added by commit 067855e651d6 ("cmdline: add polling mode")
> > but never tested or used by DPDK applications. Mark it for
> > future removal.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > doc/guides/rel_notes/deprecation.rst | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index 872847e938ed..28c458591a68 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -135,3 +135,8 @@ Deprecation Notices
> > Its removal has been postponed to let potential users report interest
> > in maintaining it.
> > In the absence of such interest, this library will be removed in DPDK 23.11.
> > +
> > +* cmdline: The function ``cmdline_poll`` does not work correctly on either
> > + Linux or Windows and is unused by any part of DPDK.
> > + It will be marked deprecated
> > + starting in the 23.07 relead and removed in DPDK 23.11.
There is no patch to mark the function deprecated as far as I know.
> This patch was put out in March and should be merged for 23.07 so that
> the dead function can be removed in 23.11.
>
> Why the no response on this? The function was never used and if anyone did
> try to use it would have discovered it was broken.
It would have helped to add few people in Cc list.
> Should it just be removed in 23.11 without warning?
We could take it with the Technical Board.
next prev parent reply other threads:[~2023-07-28 9:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 17:18 Stephen Hemminger
2023-03-14 23:01 ` Stephen Hemminger
2023-07-28 10:12 ` Maxime Coquelin
2023-06-26 16:38 ` Stephen Hemminger
2023-07-28 9:44 ` Thomas Monjalon [this message]
2023-07-28 9:45 ` Bruce Richardson
2023-07-28 10:15 ` [PATCH v2] " Bruce Richardson
2023-07-28 10:26 ` Maxime Coquelin
2023-07-28 10:39 ` Thomas Monjalon
2023-07-28 10:28 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1955982.usQuhbGJ8B@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
--cc=techboard@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).