From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6B8942F69; Fri, 28 Jul 2023 11:44:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A09940F17; Fri, 28 Jul 2023 11:44:52 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id B48BA4021E; Fri, 28 Jul 2023 11:44:49 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 56F0C5C00B9; Fri, 28 Jul 2023 05:44:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 28 Jul 2023 05:44:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1690537489; x=1690623889; bh=GZvGbkF52VYUVk2NpkNs2CU1jiaudre4VlM yHF+llxk=; b=diTKFmB6m8IK+FvN9a5AzASgFEBISKPfKIMTF3vJOjSJX1aShKu NaaCbf38fkLFsFOlqC/CIWn7oMIebniHv4DhJQlmvgKkvS1FR0w0sVyPm0/6SmTr H+oOTfrdDF8MjeOPqQ1y9RxQLjB1eBoTxzV5kxb+R7AGufmyOR9NKqqT9fhHVuVv OexS8WnsZ4dXxYC7wTjggpHoxMD/xGNIDSaXw8ZcYsxbUY/IXLYvpEQi5Skji50p lPzP9AZ4H9MMVtcaFwOZf43EQDo7B8mVEjhFiNPyBllEHh4M2nBb9CMnt5HQePBm Ky3RDprJ5zukr05VmoJH6HT038OTIzpWN9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690537489; x=1690623889; bh=GZvGbkF52VYUVk2NpkNs2CU1jiaudre4VlM yHF+llxk=; b=wS+wbe7OaQVEox1G2KeOb5zvI0Hdd6G3HyD1Gsk/c3Q14marpiv fZiyG51A3E1q4h+4z5Ayh/c82yhnsgbL86qu5YlwiKX2yB5Q1sNI2KKNkjmErUrp SvV7eWiKF7Y/Hc26jOb0WyZuYCIwQ6aV3oNtdVELVGbiqcC8Pw+uMb5DgQgloqZw atOmG9BaFD/AuSWpQYo1oxFnSxvJyHpmatTukXu3ZS9eqTFfHzZNBUOo47DS8k+g X5eYxcHNcX9rgA2JQ9GRP2FvTGa7MmBOjXfqthdXOjsbuhb27EC5o2PYhGDw7qKa rPOLsryQOkpHi/JauKPN4vzkXC9Bn03X0QQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieeigddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Jul 2023 05:44:48 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, olivier.matz@6wind.com, techboard@dpdk.org Subject: Re: [PATCH] doc: announce deprecation of cmdline_poll Date: Fri, 28 Jul 2023 11:44:47 +0200 Message-ID: <1955982.usQuhbGJ8B@thomas> In-Reply-To: <20230626093811.178348f4@hermes.local> References: <20230314171858.67446-1-stephen@networkplumber.org> <20230626093811.178348f4@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 26/06/2023 18:38, Stephen Hemminger: > On Tue, 14 Mar 2023 10:18:58 -0700 > Stephen Hemminger wrote: > > > Function was added by commit 067855e651d6 ("cmdline: add polling mode") > > but never tested or used by DPDK applications. Mark it for > > future removal. > > > > Signed-off-by: Stephen Hemminger > > --- > > doc/guides/rel_notes/deprecation.rst | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index 872847e938ed..28c458591a68 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -135,3 +135,8 @@ Deprecation Notices > > Its removal has been postponed to let potential users report interest > > in maintaining it. > > In the absence of such interest, this library will be removed in DPDK 23.11. > > + > > +* cmdline: The function ``cmdline_poll`` does not work correctly on either > > + Linux or Windows and is unused by any part of DPDK. > > + It will be marked deprecated > > + starting in the 23.07 relead and removed in DPDK 23.11. There is no patch to mark the function deprecated as far as I know. > This patch was put out in March and should be merged for 23.07 so that > the dead function can be removed in 23.11. > > Why the no response on this? The function was never used and if anyone did > try to use it would have discovered it was broken. It would have helped to add few people in Cc list. > Should it just be removed in 23.11 without warning? We could take it with the Technical Board.