From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com
 [209.85.215.52]) by dpdk.org (Postfix) with ESMTP id 3D4FA6CD3
 for <dev@dpdk.org>; Tue, 21 Jun 2016 22:49:32 +0200 (CEST)
Received: by mail-lf0-f52.google.com with SMTP id q132so42822996lfe.3
 for <dev@dpdk.org>; Tue, 21 Jun 2016 13:49:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=5T4TilljVKTqrQhx20Wym/2a3DkYhnaqWeH4NbBf6zo=;
 b=WDdsH5/+Rzk5VvM8KJSVhrgF0k8F2iQelkhCwnhRPrrYRp1HR5B55VRiNz+52A/Wko
 vmnyUZoJgEn13X5fsjK9nU0VDa5tQh1od++ABvWtjCjRllvy86EWOWErtq0+cH1bi51N
 c5h9I469tQb5Hy2DJAsgni0h72tOQGgr/0s1snNXvS9sv3QsgHy0yFg2+OKT5BCdRcZd
 fa9EuRbYpHNryi4TLjHeGHs+enUhfi6Nxi3BXNvbpCJxun3weu5Xt+TRP2Ms7PDWastc
 3ihCTrkgV1qpkmglK7J8UUSzonu04CLNimq5uFK2dbcmFofA3559wntiSDIXamP9d3bZ
 /M9A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=5T4TilljVKTqrQhx20Wym/2a3DkYhnaqWeH4NbBf6zo=;
 b=J7gh+gDm5jpBFobeB1BGvGpMNCLfnUjO4kHrOoaango9g4ifQ5u5Bg3yC+nHMm5hlZ
 9d7pRFEcgeXOetM78Td1cNxyuEd86LEcj5VSDAtB3vp5SVJlrXx7aAQ+60FUvOkoVwj9
 2udub1v0N/ONHM0NXoC1WLdsN38HdurzvM/nuHsw3JjkifqthGJvh/lVS5C2X15K4/u8
 Z+hc/DMU9htQbt+Zxkg6Pv7pwzbIepX+Ol+Yc/H6UBS8IRGwrld9M4RCTeNmwGhJExkE
 dwRNAecUicXphlGFNq7SW5ZYYCQ+lhFnlMHxcLldVxzL3R1srlwzjkC+YzoWrtRH1gqT
 k/Vw==
X-Gm-Message-State: ALyK8tJzTjXRgaoQ02lNtKEdTqIXB4GDYayvqVlo8rUmvCzkTKL4AUABfcUnWNmQu0qRHMqK
X-Received: by 10.28.109.198 with SMTP id b67mr5050264wmi.53.1466542171823;
 Tue, 21 Jun 2016 13:49:31 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id t67sm4641846wma.1.2016.06.21.13.49.29
 (version=TLSv1/SSLv3 cipher=OTHER);
 Tue, 21 Jun 2016 13:49:30 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: cristian.dumitrescu@intel.com
Cc: dev@dpdk.org, Jasvinder Singh <jasvinder.singh@intel.com>
Date: Tue, 21 Jun 2016 22:49:29 +0200
Message-ID: <19575533.UNkKiejxmv@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1466067875-165380-1-git-send-email-jasvinder.singh@intel.com>
References: <1466067875-165380-1-git-send-email-jasvinder.singh@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port
	section
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jun 2016 20:49:32 -0000

2016-06-16 10:04, Jasvinder Singh:
> Replace APP_PARAM_ADD_LINK_FOR_TXQ with APP_PARAM_ADD_LINK_FOR_TM macro
> in TM (Traffic Manager) port section parsing function. This macro adds
> nic ports entry specified in TM port section of the application
> configuration file to the application parameters structure.
> 
> Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration parser")
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Already fixed in 81d084dd2aa8 ("examples/ip_pipeline: support KNI")

Cristian, you should not ack a patch which do more than announced in
the title. This pipeline KNI patch do a lot of things without any
explanation for the fixes.
1 explanation = 1 patch