From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 6DB2C1B474 for ; Fri, 29 Jun 2018 16:24:47 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 072D2859AA; Fri, 29 Jun 2018 14:24:47 +0000 (UTC) Received: from [10.36.112.15] (unknown [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1D352156880; Fri, 29 Jun 2018 14:24:44 +0000 (UTC) To: "Iremonger, Bernard" , "dev@dpdk.org" Cc: "ailan@redhat.com" , "jan.scheurich@ericsson.com" , "vkaplans@redhat.com" , "Richardson, Bruce" , "thomas@monjalon.net" , "Ananyev, Konstantin" , "Yigit, Ferruh" , Jens Freimann References: <20180623080840.315-1-maxime.coquelin@redhat.com> <20180623080840.315-2-maxime.coquelin@redhat.com> <8CEF83825BEC744B83065625E567D7C260CB8BEC@IRSMSX108.ger.corp.intel.com> <195bb20b-441a-571e-8925-6db0a8af56c2@redhat.com> <8CEF83825BEC744B83065625E567D7C260CBAC13@IRSMSX108.ger.corp.intel.com> From: Maxime Coquelin Message-ID: <195b7eb6-8c0f-316d-25dd-ce2fd6c5f2e0@redhat.com> Date: Fri, 29 Jun 2018 16:24:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CBAC13@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 29 Jun 2018 14:24:47 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 29 Jun 2018 14:24:47 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 14:24:47 -0000 On 06/29/2018 04:05 PM, Iremonger, Bernard wrote: > Hi Maxime, Thomas, > > >> Subject: Re: [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy >> neighbour >> >> Hi Bernard, >> >> On 06/26/2018 01:09 PM, Iremonger, Bernard wrote: >>> checkpatch.pl is showing the following warnings: >>> >>> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 >>> #122: FILE: app/test-pmd/noisy_vnf.c:1: >>> +/* SPDX-License-Identifier: BSD-3-Clause >> >> I'm not sure to get what is wrong here, any thoughts? >> > > I have looked at code and compared it with other license headers and it looks ok to me. > > Hi Thomas, > > Could you take a look please to see if you can spot something. > >> >> >>> WARNING: line over 80 characters >>> #394: FILE: app/test-pmd/parameters.c:1154: >>> + if (!strcmp(lgopts[opt_idx].name, >>> + "noisy-buffersize-before-sending")) { >>> >>> WARNING: line over 80 characters >>> #402: FILE: app/test-pmd/parameters.c:1162: >>> + if (!strcmp(lgopts[opt_idx].name, >>> + "noisy-flush-timeout")) { >>> >>> WARNING: line over 80 characters >>> #410: FILE: app/test-pmd/parameters.c:1170: >>> + if (!strcmp(lgopts[opt_idx].name, >>> + "noisy-memory-footprint")) { >>> >>> WARNING: line over 80 characters >>> #413: FILE: app/test-pmd/parameters.c:1173: >>> + noisy_vnf_memory_footprint = >>> + (uint16_t) n; >>> >>> WARNING: line over 80 characters >>> #418: FILE: app/test-pmd/parameters.c:1178: >>> + if (!strcmp(lgopts[opt_idx].name, >>> + "noisy-nb-rnd-write")) { >>> >>> WARNING: line over 80 characters >>> #426: FILE: app/test-pmd/parameters.c:1186: >>> + if (!strcmp(lgopts[opt_idx].name, >>> + "noisy-nb-rnd-read")) { >>> >>> WARNING: line over 80 characters >>> #434: FILE: app/test-pmd/parameters.c:1194: >>> + if (!strcmp(lgopts[opt_idx].name, >>> + "noisy-nb-rnd-read-write")) { >> >> The above ones were left intentionally for consistency with code around them. >> >> Should I fix them? (I'm fine doing it if you prefer) > > I have looked at the code and I think it would be better to fix them. > The existing code has much shorter strings. > There is some flexibility around the line length, but it depends on the tree maintainer. Great, thanks for the quick feedback. Maxime > Regards, > > Bernard. >