From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0CBF71EF84 for ; Wed, 13 Jun 2018 17:19:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 969B221B09; Wed, 13 Jun 2018 11:19:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 13 Jun 2018 11:19:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=V1SL3G8pCHyI+2ZFE8F+cclqZ2 xmjKVvhzkjcS2c+OU=; b=OebtLAPGQ9z6uMqz+qAVRTF7aUQvEkUtcQwUYQZtnv cZCYOciJMBMaDRz7zSUe6DVVRjUO0ziZz+OWNFM9SuezcRe5AvcuPnTkrak7eNvU tqwoPk5cBceQQCjuLk7eHQcFXflFbLQKd99Tj9jrbSeXjGNN0ENZYg6aNU+IoBN9 E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=V1SL3G 8pCHyI+2ZFE8F+cclqZ2xmjKVvhzkjcS2c+OU=; b=GnNWVX4xojrwRI8mt8Ukrf oWw6WjHZgapZmdz9OJt6rq2xQctjhWUK+piY3QBkR00/ADyuHMP10dR1tKylMMOz B6D3VkUAwyDTYr4xRf6cIAcpYS7aXwnIc7M7GLSUU8LALMZOvzaB8vFvxpDKi6OV A33gfeUefCPNTcF395FWdIdEaMLpAhwGYfbp1RpRPkwUvn9V+lkCD1wo7iTkCD9w PifQU+S14/6z1aTvgZ0vGDvnEKwD+yHv/vNjQqpvHuwi3wfNETfE8SOF2FDLcvEK i7VFfN3XhlmB8ecJHQodXTVz5jkh4ygZUDvZVoe79o0ssrI1sZwPlEevqNhXlhfw == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 882841025D; Wed, 13 Jun 2018 11:19:23 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Shahaf Shuler , "Xueming(Steven) Li" , Wei Dai , Qi Zhang , Andrew Rybchenko Date: Wed, 13 Jun 2018 17:19:22 +0200 Message-ID: <19602770.WDo9s5UZfG@xps> In-Reply-To: References: <20180531132245.19424-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: force RSS offload rules again X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2018 15:19:25 -0000 04/06/2018 09:56, Shahaf Shuler: > Sunday, June 3, 2018 5:15 PM, Ferruh Yigit: > > Subject: Re: [PATCH] ethdev: force RSS offload rules again > > > > On 6/3/2018 11:41 AM, Shahaf Shuler wrote: > > > Thursday, May 31, 2018 4:23 PM, Ferruh Yigit: > > >> Subject: [PATCH] ethdev: force RSS offload rules again > > >> > > >> PMDs should provide supported RSS hash functions via > > >> dev_info.flow_type_rss_offloads variable. > > >> > > >> There is a check in ethdev if requested RSS hash function is > > >> supported by PMD or not. > > >> This check has been relaxed in previous release to not return an > > >> error when a non supported has function requested [1], this has been > > >> done to not break the applications. > > >> > > >> Adding the error return back. > > >> PMDs need to provide correct list of supported hash functions and > > >> applications need to take care this information before configuring > > >> the RSS otherwise they will get an error from APIs: > > >> rte_eth_dev_rss_hash_update() > > >> rte_eth_dev_configure() > > > > > > Are the current app/examples in DPDK tree behave accordingly? > > > > I tried a few which were good but I don't know about all. > > > > That is why we should merge this patch early so that we can detect and fix > > ones fails. > > Acked-by: Shahaf Shuler Acked-by: Thomas Monjalon