From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 184791B21A for ; Fri, 2 Nov 2018 11:43:16 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D4ECE982; Fri, 2 Nov 2018 06:43:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 02 Nov 2018 06:43:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=cVBP0T80DuywgW/N8GeMPbYLlhAsQLdSrExB035L8ts=; b=HQYulsz/7lnJ /+oq0RIpPrW5mS+xirV6ht3QoM3hd0LYxC/9iGxRKDMYRNFk0QmY2FvR51dtGa9k E+UXIryPMYrQfsCFETOaEQtLBg65Im/anMjQY9nXm5z52aWhreKGDrXBDfUOJPbz cluHZ/dZQfh61YUkjKWjzSinxMenYsI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=cVBP0T80DuywgW/N8GeMPbYLlhAsQLdSrExB035L8 ts=; b=lzE5gbItZw2sqZZyuQ3rQqaXeMHBhEqD1254Eum3Zkcsmx8t5OdYH+t8R hYQutxajnu+0vovVTh3Lky0idbb9B/FTBJe8+CSq7MVm2FRXezlm/dItFtejQFYA uLDp+za53AY+/6reCwX/6Ron+tAeCYZCVvytu4siS6A4aieMH6raT2YjBVx+tx4a wC7uc4bZM4wp4q7H80UbOolM3ZR+lj3qT5yCpPFaj8D2agVFpskH1bij3cuNLOqK MQn7+1Yvl7G3DRjRjcOxL5sQJqiIa7cJ763cJmzr4yGAVetNocGyGrsaLAPfawWi mO66w3m1s8tFpBLdRcoGyOLEjSUww== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2E83BE454E; Fri, 2 Nov 2018 06:43:13 -0400 (EDT) From: Thomas Monjalon To: Arnon Warshavsky Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com Date: Fri, 02 Nov 2018 11:43:12 +0100 Message-ID: <1962879.kOuKm9R6DT@xps> In-Reply-To: References: <1541138405-6608-1-git-send-email-arnon@qwilt.com> <4348558.Aku75RrXBD@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] devtools: add explicit warning messages for forbidden tokens X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 10:43:16 -0000 02/11/2018 11:37, Arnon Warshavsky: > > > > > + message="Using explicit .svg extension in figures instead of .*" > > > awk -v FOLDERS='doc' \ > > > -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \ > > > -v RET_ON_FAIL=1 \ > > > + -v MESSAGE="$message" \ > > > -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk > > \ > > > "$1" > > > } > > > > Why using a variable for message in the second check? > > > > > > This was to avoid the 80 characters long line warning I get. > It also seems more convenient should there be a need for multi-line > messages. > Is there a more preferred way in such a case of a passed parameter? I think I prefer passing the string directly. You can make a shorter message: Using explicit .svg extension in rST instead of .* or Using explicit .svg extension instead of .*