From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 731EAA0A02; Mon, 5 Apr 2021 11:53:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 340D5140DF1; Mon, 5 Apr 2021 11:53:05 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 4DB8A4067C for ; Mon, 5 Apr 2021 11:53:03 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 989A858029A; Mon, 5 Apr 2021 05:53:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 05 Apr 2021 05:53:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= j6VS857+/3Ww7KEu4cxdj+6fvIoJnnAby6fkTinmg+U=; b=dLA1DaH6J8TQ0LBB llfNltAhRnONmH8X5k/zUAQpEoReEhjCm+cxvC2VqfVVUQ7E/mCynwPrJXaIRcdW qo/ONtHN2DkRZCvHwcO3+M/djwwKjGxHLjzYnAvpFn6kIP+hEctFJJzHM1FE/97E ZItf2S+PbwTDHTGqclIo2YiQSYXTVNUB2a6YPu6m/2wZFQiFUMs4fyXNe0Q7YLxl pYu7qo1Y/oDSKYjdT+cDZ/8sWaMe+q0I0KVC//QY1pz90XNW9EQasuvCNuVleuTg A89Nru/y7FDT6b22QTo1QRF5ZB8K1QWt4v0WDErFAmUqjS2rLuDvORl8VEQggxiY PMg23w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=j6VS857+/3Ww7KEu4cxdj+6fvIoJnnAby6fkTinmg +U=; b=midVQjaxlOlB0lGxarRYkcHReZY6N05ajaFFeywhjYZiiHI55MsDwxt3S sFGIATNaaaicYjTKwbijV8jj1d6ECPkGW0Jeq3GZWdLfRJ2pk76+lB9Nw8iZ/efy d4ny2FOoYi2A5YELQgB+c5gU4lfttp6wdpiRokBWU0zNJjixJ58YcUqL4NqF/RgN UjQrdYwis+RN56zz4w/Mu+6d6icW6x61jnS9nX4sZwKH/cZkrAaz3dhxaVXBsrkC dHlcIhiTGeEIvV5KGl6zGgT2+UCzLfscBJ+0prtT3HKHq3bxEy7YPlpvjKij5cbn +nIyQ/1E/msmfTUTbLrOIp6RYFEJw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejvddgvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhephfeugfeufeehueejhefhjefftdekveeivdffjedukeejudehffeh gfehgeduudehnecuffhomhgrihhnpehpmhgurdhnvghtnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B2ADD108005F; Mon, 5 Apr 2021 05:52:59 -0400 (EDT) From: Thomas Monjalon To: Rosen Xu , Xiao Wang , David Marchand Cc: dev@dpdk.org, John Griffin , Fiona Trahe , Deepak Kumar Jain , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta , Tianfei zhang , Bruce Richardson , Nipun Gupta , Hemant Agrawal Date: Mon, 05 Apr 2021 11:52:58 +0200 Message-ID: <1964405.yerxsFgust@thomas> In-Reply-To: References: <20210310140107.2730088-1-thomas@monjalon.net> <20210310140107.2730088-4-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/3] drivers: align log names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/03/2021 11:33, David Marchand: > On Wed, Mar 10, 2021 at 3:02 PM Thomas Monjalon wrote: > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > > index 6a1b44bc77..bf7afe4610 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -25,7 +25,7 @@ > > > > #include "base/ifcvf.h" > > > > -RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.net.ifcvf_vdpa, NOTICE); > > +RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.vdpa.ifcvf, NOTICE); > > The driver is in drivers/vdpa/ifc, I would expect pmd.vdpa.ifc I'm not sure for this one. My understanding is that the name of the driver can be a little different of the directory name, especially if having multiple drivers in a directory. Here there is only VF in IFC. > We have some little variations for the af_packet and bonding drivers, > worth aligning from my pov. > drivers/net/af_packet/rte_eth_af_packet.c:RTE_LOG_REGISTER(af_packet_logtype, > pmd.net.packet, NOTICE); > drivers/net/bonding/rte_eth_bond_pmd.c:RTE_LOG_REGISTER(bond_logtype, > pmd.net.bond, NOTICE); Yes good catch, will align these two. > And ipn3ke is odd too: > drivers/net/ipn3ke/ipn3ke_ethdev.c:RTE_LOG_REGISTER(ipn3ke_afu_logtype, > pmd.afu.ipn3ke, NOTICE); I agree it's strange, but I don't understand ifpga and ipn3ke enough to have a good judgement. I feel more naming have to be carified in this driver. I will highlight ifc and ipn3ke in v2 to have a conclusion. Rosen, Xiao, please comment.