From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BECBD2A5E for ; Wed, 22 Feb 2017 20:04:38 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Feb 2017 11:04:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,195,1484035200"; d="scan'208";a="68389037" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by fmsmga005.fm.intel.com with ESMTP; 22 Feb 2017 11:04:36 -0800 To: Vasily Philipov , dev@dpdk.org References: <74798f347a5b1fad28037b713ad83048c227a2ca.1487685098.git.vasilyf@mellanox.com> <74798f347a5b1fad28037b713ad83048c227a2ca.1487770570.git.vasilyf@mellanox.com> Cc: Adrien Mazarguil , Nelio Laranjeiro From: Ferruh Yigit Message-ID: <1964838c-9f28-1680-705d-148bcf0e816c@intel.com> Date: Wed, 22 Feb 2017 19:04:35 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <74798f347a5b1fad28037b713ad83048c227a2ca.1487770570.git.vasilyf@mellanox.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx4: split the definitions to the header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2017 19:04:39 -0000 On 2/22/2017 1:42 PM, Vasily Philipov wrote: > Make some structs/defines visible from different source files by placing > them into mlx4.h header. > > Signed-off-by: Vasily Philipov > --- > drivers/net/mlx4/mlx4.c | 183 ++-------------------------------------------- > drivers/net/mlx4/mlx4.h | 187 +++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 189 insertions(+), 181 deletions(-) > > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index 79efaaa..82ccac8 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -1,8 +1,8 @@ > /*- > * BSD LICENSE > * > - * Copyright 2012-2015 6WIND S.A. > - * Copyright 2012 Mellanox. > + * Copyright 2012-2017 6WIND S.A. > + * Copyright 2012-2017 Mellanox. Can someone knowledgeable about Copyright help please? What is the year field in Copyright line for? And above change updates Copyright from 2012 to 2012-2017, is this correct? > * > * Redistribution and use in source and binary forms, with or without > * modification, are permitted provided that the following conditions > @@ -68,10 +68,6 @@ > #pragma GCC diagnostic error "-Wpedantic" > #endif Above invisible lines are "#include " wrapped with #pragma for pedantic. That piece moved to "mlx4.h" [1], which included a few lines later, so can these line be removed from this line? > > -/* DPDK headers don't like -pedantic. */ > -#ifdef PEDANTIC > -#pragma GCC diagnostic ignored "-Wpedantic" > -#endif Comment says "DPDK headers don't like -pedantic", won't removing #pragma cause compile error with pedantic option? > #include > #include > #include > @@ -86,9 +82,6 @@ > #include > #include > #include > -#ifdef PEDANTIC > -#pragma GCC diagnostic error "-Wpedantic" > -#endif > > /* Generated configuration header. */ > #include "mlx4_autoconf.h" > @@ -96,21 +89,6 @@ > /* PMD header. */ > #include "mlx4.h" > <...> > diff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h > index 4c7505e..70c9ecd 100644 > --- a/drivers/net/mlx4/mlx4.h > +++ b/drivers/net/mlx4/mlx4.h <...> > + > +/* Verbs header. */ > +/* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */ > +#ifdef PEDANTIC > +#pragma GCC diagnostic ignored "-Wpedantic" > +#endif > +#include > +#ifdef PEDANTIC > +#pragma GCC diagnostic error "-Wpedantic" > +#endif --> [1] <...> > + > +void priv_lock(struct priv *priv); > +void priv_unlock(struct priv *priv); It can be good to mention in commit log that these functions are now exported. > + > #endif /* RTE_PMD_MLX4_H_ */ >