From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CF50A00C2; Thu, 24 Nov 2022 09:21:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F26542DAA; Thu, 24 Nov 2022 09:21:11 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id A591842C4D for ; Thu, 24 Nov 2022 09:21:10 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id F203D5C00E5; Thu, 24 Nov 2022 03:21:09 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 24 Nov 2022 03:21:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669278069; x= 1669364469; bh=KJcR/F0WdEJk4JsuT7kEXErfDttF1VPUJGDVyRdrojg=; b=T hwVemwkN3zG0KkW4R1ZO4L+OJCUxhFs8Oz3Ct+Pz31J6yfeKNxY1TjqDKnj70fRF 2yrQtwtGiB4hyiE5YBdtQVKKj7JcyxjalCmzZmz6yEoFplrIv3R5/KSH68ez8/7p yLImnOoj/P8XjKH/nsrXO4vyS9jOpGCfSowKIozuLvEBSxUWgRIry/yssHFA1f7v 4+9dlMTPzwmrOo6X44nxdbsXc6g4e190BuZNnKlZe0mMyQdP1F5EtKgzJpHi+xW3 SHLtglCyyI/RnUQuWOD4XmSUR3i1oNZLnx1ahZ3pbimDx8tR+WZVMMET71eA1sbl qoU4rOJkfmGDlymDavsaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669278069; x= 1669364469; bh=KJcR/F0WdEJk4JsuT7kEXErfDttF1VPUJGDVyRdrojg=; b=o s+TxSj3p2YmsyU955uXiqSVYyCyORKa8d6p9gvIp2SsI1/7++ek0XLxy6b/wthQ0 XqeUo9qjQ7/2qYeIpEjGSnPVU+LpFukJyC6idAD7o31U5U0sff41xgYFrxFisjuj B6YTxZuv5Bcz8o/ASLUeqR+dg5VPx3DL5ghIX80zZMjUtZzN0TwEKg2ckG1ESuf2 /7yG54/4dmf2AyqaelZZhQLqnSgGkxDqmQ0tF7e7undCnvJCyQgAl91VSuzB2y9+ CiG3jqRPldhQ52SvMaqFHl+dl+eduT0GcIGdxgWrq+yVXDF4qH/ss8yZ5gdowypj pL2oNxWhL7n/EzQ3JwCqg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedriedvgdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Nov 2022 03:21:08 -0500 (EST) From: Thomas Monjalon To: "Chautru, Nicolas" Cc: "dev@dpdk.org" , "gakhil@marvell.com" , "maxime.coquelin@redhat.com" , "Vargas, Hernan" Subject: Re: [PATCH v2 2/2] doc: simplify the binding steps Date: Thu, 24 Nov 2022 09:21:07 +0100 Message-ID: <1965125.PIDvDuAF1L@thomas> In-Reply-To: References: <20221115195914.34700-1-nicolas.chautru@intel.com> <3507975.LM0AJKV5NW@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/11/2022 02:09, Chautru, Nicolas: > Hi Thomas, > > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Wednesday, November 23, 2022 12:35 AM > > To: Chautru, Nicolas > > Cc: dev@dpdk.org; gakhil@marvell.com; maxime.coquelin@redhat.com; > > Vargas, Hernan > > Subject: Re: [PATCH v2 2/2] doc: simplify the binding steps > > > > 22/11/2022 22:21, Chautru, Nicolas: > > > From: Thomas Monjalon > > > > 15/11/2022 20:59, Nicolas Chautru: > > > > > -The PCI virtual functions must be configured before working or > > > > > getting assigned -to VMs/Containers. The configuration involves > > > > > allocating the number of hardware > > > > > +The device must be configured to work properly. > > > > > +The configuration involves allocating the number of hardware > > > > > queues, priorities, load balance, bandwidth and other settings > > > > > necessary for the device to perform FEC functions. > > > > > > > > > > This configuration needs to be executed at least once after > > > > > reboot or PCI FLR and can -be achieved by using the functions > > > > > ``rte_acc10x_configure()``, > > > > > +be achieved by either using ``pf_bb_config`` or the function > > > > > +``rte_acc10x_configure()``, > > > > > which sets up the parameters defined in the compatible > > > > > ``acc100_conf`` > > > > structure. > > > > > +This is the method used in the bbdev-test test application. > > > > > > > > Clearly this patch is more than "simplifying binding steps". > > > > > > > > > > The intent has indeed to remove much of the binding steps to point to > > generic document, then minor updates to keep the flow readable and > > informative. > > > Let me know what you are referring to specifically which caught your eyes. > > > Some of the FPGA configuration steps were also simplifies to align with the > > other PMDs. > > > We can rename if you prefer as doc: simplify the binding and configuration > > steps. Or split but unsure of the value. Up to you. > > > > You are adding more information. > > One example is above. > > I think it deserves a separate commit to understand which info you add and > > why. > > > > To avoid iterations, you just want to split this commit again into two: > - doc: simplify the binding steps > - doc: simplify and clarify the configuration steps > > Thanks for confirming. > Nic Yes