From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 2CAD95A31
 for <dev@dpdk.org>; Wed, 13 May 2015 11:32:16 +0200 (CEST)
Received: by wicnf17 with SMTP id nf17so47942240wic.1
 for <dev@dpdk.org>; Wed, 13 May 2015 02:32:16 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=S+p/cJqRsmiGPYdJFqLPN3W3x3rtR+rrkEOHJ9oGb/0=;
 b=fM4IbwodVrnjleaOrHU1EWApNV5QJHmbLdghZJZjbAinZVGjN2tJmS2QI6IK3VI4rG
 INdFLot11XIs7pMMD0Vk7cXOyQHhBaSi94+10lrFc0mbyXM/Aufsk7FjvAJEcZVb3VqF
 FDhRE3wxq8CqhfGD1tx8Gd6vB0SoIqweSPdjCC7jiCjk0V+hE7XDouXT1dXLVR7Li4l4
 wROsGn76rLrqsJSPmZ8f6YcaTYHbSt55eHiV0HZOF2fHWtHD76IsLz+K9VPWgn+1MBo6
 lutdeiZiVmgrDWzrE9vFjvA5njzsMApTMfiyg4J+sI2reBAhyicI5oPfmgGAFCIXowuU
 N/Mg==
X-Gm-Message-State: ALoCoQn+rjNLV16xVvcfvg/sdOaB7FsfONX0UYmi8YlfQ+grRmMvk68ylvu3BsWd+0JYtgFCLmQX
X-Received: by 10.194.123.4 with SMTP id lw4mr37404603wjb.94.1431509536056;
 Wed, 13 May 2015 02:32:16 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id lh8sm20000097wjc.23.2015.05.13.02.32.14
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 13 May 2015 02:32:15 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 13 May 2015 11:31:31 +0200
Message-ID: <1965571.qvjumJN0Zx@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; )
In-Reply-To: <20150430162703.GA5972@bricha3-MOBL3>
References: <1430239000-30881-1-git-send-email-stephen@networkplumber.org>
 <1430239000-30881-2-git-send-email-stephen@networkplumber.org>
 <20150430162703.GA5972@bricha3-MOBL3>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] uio: fix irq handling with igb_uio
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 13 May 2015 09:32:16 -0000

2015-04-30 17:27, Bruce Richardson:
> On Tue, Apr 28, 2015 at 09:36:38AM -0700, Stephen Hemminger wrote:
> > The introduction of uio_pci_generic broke interrupt handling with
> > igb_uio. The igb_uio device uses the kernel read/write method to
> > enable disable IRQ's; the uio_pci_generic has to use PCI intx
> > config read/write to enable disable interrupts.
> > 
> > Since igb_uio uses MSI-X the PCI intx config read/write won't
> > work.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Fixes: c112df6875a5 ("eal/linux: toggle interrupt for uio_pci_generic")

Applied this fix without the rest of the series (incomplete enhancements).
Thanks for the good work on pci interrupts.