From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Stephen Hemminger <stephen@networkplumber.org>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] locking around rx_intr_enable/disable?
Date: Wed, 27 Feb 2019 11:57:03 +0300 [thread overview]
Message-ID: <1967530f-6d1b-2895-b3f0-c6863ce6a040@solarflare.com> (raw)
In-Reply-To: <20190226101444.752ee2da@shemminger-XPS-13-9360>
On 2/26/19 9:14 PM, Stephen Hemminger wrote:
> I noticed an anomaly in how receive interrupt control is done.
>
> In l3fwd-power there is a per-port lock around calls to enable interrupts
> but no locking around the call to disable interrupts. This looks broken
> since intr_disable requires multiple operations on some hardware.
>
> There are three better options:
> 1) do locking in rte_eth_dev (not application)
> 2) push any necessary locking down into the driver
> 3) lock on both places in l3fwd-power (and other usages)
>
> I am thinking #1 is easiest solution.
>
> Which ever solution is done, the documentation should be as well.
I think #2 is a way to go - some drivers require locking, some not.
I think it is a bad idea to enforce locking for drivers which do not
require it.
Andrew.
prev parent reply other threads:[~2019-02-27 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 18:14 Stephen Hemminger
2019-02-27 8:57 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1967530f-6d1b-2895-b3f0-c6863ce6a040@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).