From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 71D4A4CA1
 for <dev@dpdk.org>; Wed,  7 Mar 2018 16:07:11 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id F1BD820BB0;
 Wed,  7 Mar 2018 10:07:10 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Wed, 07 Mar 2018 10:07:10 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=ff2aN2tWnqn5mtfcCo0XVL/vUK
 Ivbgow5o9y81cvCz4=; b=qjh3qrBeceF6aI3/0b3s66oLqUPIpcH76nlbZ+zwlD
 xoGndfC4z+SjgWJAf/D1Gl9nRUYoyajL3dpb/UTiRQJWsBx6WUjHiQBQeP2hPpuZ
 VVUcET1eH7nIBjJyhyBYhby2o7umWlzW1B1huvG317Y4WY8x9Lmz6+Bq+WwRfzdk
 Y=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ff2aN2
 tWnqn5mtfcCo0XVL/vUKIvbgow5o9y81cvCz4=; b=Xhqddun4j9NLLwYyejVDb5
 jeWrGuxrUW9Jmy6v6XpPBtdCNqNYvqmD/CXYTIRDrD/yUZ1nHZHXrLhEc80XUR3Z
 s09M6q4oKuuQKu00N05s0OiXSEyJgGb6cSm4w4MR9Hx89iwkYLv4YS+YQdX+wT5B
 uSqXK+V2t1iJJdjQxNrEtbeCEttE3/9MIwQrOi9MNmmcdhtZy1oWdHJW+Zsr2afW
 nRTpcZeSuEQOgcylb6trfGosqDCSgyKSar8go+cIS2hlHjzod/grD9u+A2xKq9Za
 Rz7r8fkxQ2RZM3SvtkFfKmCLhBfPxjVXwjK5i+4bAF3TcBgnr35NAajdJ0lzsljg
 ==
X-ME-Sender: <xms:HgCgWpUn_8J1H38eJqwQnXt3jfL1ny8yWp_4zNzNZZaVz6pGoR7PSQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 4B0DD24651;
 Wed,  7 Mar 2018 10:07:10 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Arnon Warshavsky <arnon@qwilt.com>, "Burakov,
 Anatoly" <anatoly.burakov@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Date: Wed, 07 Mar 2018 16:06:22 +0100
Message-ID: <1968690.y4bVNFghIW@xps>
In-Reply-To: <CAKy9EB1SaOVFDyDnszTJUGH9gON5-ULRf86kRcxRXT6WiPMWjg@mail.gmail.com>
References: <1520360928-9375-1-git-send-email-arnon@qwilt.com>
 <81ecbc4a-0200-3b42-8da1-fe87e8c14c04@intel.com>
 <CAKy9EB1SaOVFDyDnszTJUGH9gON5-ULRf86kRcxRXT6WiPMWjg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eal: register rte_panic user callback
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Mar 2018 15:07:11 -0000

07/03/2018 14:23, Arnon Warshavsky:
> >
> > Can we add a compile warning for adding new rte_panic's into code? It's a
> > nice tool while debugging, but it probably shouldn't be in any new
> > production code.

Yes could be nice to automatically detect it in drivers/ or lib/ directories.


> I thought about renaming the current function and calls to something like
> deprecated_rte_panic()
> , and keep the old API with __rte_deprecated.
> Is this kind of API break acceptable?

No, rte_panic can be used in applications.