From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5DDB34CB3 for ; Tue, 8 May 2018 22:20:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EF89620B26; Tue, 8 May 2018 16:20:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 08 May 2018 16:20:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=CMeI3TLcg31hWEdwDMpiVfv9wn bHdX8ZTgq8JmUXvME=; b=BByWOoRZPC3m8XGx7+YTlQW2clxgnoVDvIo+6zIqKG hiHTgxBYYiFzvrT0kzFd45l8As5LbITGZx+3LK/PrDFef+UEXQhVFrF12AzM1aY9 BrPvhnumvSopGLdofa2IpyhQUikYmEjoAvjnnnemRKSPmNVYohMEpDFrPP5w0GoE c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=CMeI3T Lcg31hWEdwDMpiVfv9wnbHdX8ZTgq8JmUXvME=; b=f0HgtCqNDOwIzPzK44/Q5i F9/LRrUlrDqW6nXkMNRv0+wvhOCGZWsNxkUihcocRUXMxKiETwHdda8TOS/OUX1E a29YxUKJfZqm/09PZpnFjnQOrq6WLrhRmAnKMP3mdHw3RxG0+RvnE19bJ6W2F+8C x/rikpY8dBAbM11rURUWJ4TaZJsGBYSDVTyq/Pv62g0XSdBxV2Dk3gaDynEXqAky XACvERBLGGpSQ+b4RaS6gwcqC9UloWUfbRnRb8ZktYFCPHBsz87rGKne6xPYJRUS W9D63QODTrsOjvb7mIF2IQH1t4h0feM9Q7z0RiV3tgirUffebiwhkleC3CxfHRlg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 338F8E50A0; Tue, 8 May 2018 16:20:16 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Bruce Richardson Date: Tue, 08 May 2018 22:20:15 +0200 Message-ID: <1968691.VWAu9saNLK@xps> In-Reply-To: <4409303.1sNuYAC1ue@xps> References: <20180430125035.GB100464@bricha3-MOBL.ger.corp.intel.com> <4409303.1sNuYAC1ue@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/2] mem: unmap unneeded space X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 20:20:17 -0000 02/05/2018 23:00, Thomas Monjalon: > 30/04/2018 14:50, Bruce Richardson: > > On Mon, Apr 30, 2018 at 12:21:43PM +0100, Anatoly Burakov wrote: > > > When we ask to reserve virtual areas, we usually include > > > alignment in the mapping size, and that memory ends up > > > being wasted. Wasting a gigabyte of VA space while trying to > > > reserve one gigabyte is pretty expensive on 32-bit, so after > > > we're done mapping, unmap unneeded space. > > > > > > Signed-off-by: Anatoly Burakov > > > --- > > > > > > Notes: > > > v2: > > > - Split fix for size_t overflow into separate patch > > > - Improve readability of unmapping code > > > - Added comment explaining why unmapping is done > > > > > Acked-by: Bruce Richardson > > I am not confident pushing this change post-rc1. > Please can we have more validation tests with this patch? Any news about validation tests?