From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AF6009B67 for ; Mon, 8 Oct 2018 15:06:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4F9012211E; Mon, 8 Oct 2018 09:06:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 08 Oct 2018 09:06:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=FQZnZY4dcL70efGx4esxbjktb3/hHRs7urHh9RsGiNo=; b=Lt6RADmonMUg /897cidhVBqy7mADiqFaO7EAsiVCRgGKuYwkdrWLpSfkM2J9xKAjk+8fW+8jNMcV tg6xk5W0XXMyfQ7gsU/yw9d53+nMnezHJHXUv47y70Sah882pbtJSdvbJlCbd0TP eeoRVLg3AGZUoMfPszcDzt8C3dhgi88= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=FQZnZY4dcL70efGx4esxbjktb3/hHRs7urHh9RsGi No=; b=BDuLexrgDQmI23sXd2GvKLtSUlKEQAlwBfCzMgS8bsXzpDD7gBxxH4F3w DZtCKVY1ZSvlQZQvLpQQr8xgQ8u+w29+QE10rCYUiHj2B699TE42omhSCLdoOiYX jrmYl+bCGrlxKLH/5APeKnsGe5hctRt9p/V2ogd2M8kJgzByN/hEkFBM6OT5IlYW Lqx2t0HAH04UZ2DAHpA9L38oP7HNNNVNjUdlN8isq5kwZVp0K4FKlhZb7RYsgt0d KgE+GbmFjS1vOEEpoI/sZ10nKjT+4YhQsOgh8ED3ceRVYwtqJtgNppEKYbzUgGnW qhYt4AhqOlZbbrl+8TcF865EJFksg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B4FFCE46B8; Mon, 8 Oct 2018 09:06:13 -0400 (EDT) From: Thomas Monjalon To: "Joseph, Anoob" Cc: dev@dpdk.org, Akhil Goyal , Pablo de Lara , Jerin Jacob , Narayana Prasad , Ankur Dwivedi , Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj Date: Mon, 08 Oct 2018 15:06:12 +0200 Message-ID: <1968766.8UszeQjU0E@xps> In-Reply-To: <9f88e0e8-5999-8eb3-a47b-0bbfa6d5d017@caviumnetworks.com> References: <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <4676876.qg1oKfV5S6@xps> <9f88e0e8-5999-8eb3-a47b-0bbfa6d5d017@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 13:06:16 -0000 08/10/2018 14:58, Joseph, Anoob: > On 08-10-2018 18:03, Thomas Monjalon wrote: > > A lot of patches are split in 2 parts for common/cpt and crypto/octeontx. > > I think it is useless most of the time. > > You are allowed to update any related code in the common part > > while implementing some features in the crypto driver. > The tool, check-git-log.sh was giving warnings when we were making > changes in two places. That's one reason we had to split it this way. By definition, a tool is silly :-) It is raising a warning to ask you checking manually. If you know what you do, you can ignore this warning.