From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 875972BC9 for ; Tue, 8 Aug 2017 15:13:20 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3FD9520A5E; Tue, 8 Aug 2017 09:13:19 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 08 Aug 2017 09:13:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=+a3vnxLCqSFCpoE dHeMnJFpkAfCx1v30fBhvE8kbCmU=; b=Lr8GAIDtH1DNJfDVc87EwzHsivgC9Gq oPc/AVtaI/qbg/ARKrCrLLS2OiMQFkinQoGZEsKxp99NSHVxfiZIa5IoEZuF28WQ f5ueyEBrq9aIpxIAdqklPWzlI2hgEK7arDPFolLvhHOFmiq26SPEJPmXzCedfAtF LCphP5QvvHPE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=+a3vnxLCqSFCpoEdHeMnJFpkAfCx1v30fBhvE8kbCmU=; b=YRS7nvod Ql7MHZBBVQCGl7vMmr6C3jDDn9VSdHH5JeaIsQa4uuGxCHW+3rcelqbJGRaZxDRF GxXt5fsLoI/xxso468Y+AVak+7TMX4s08OCyt1ZAb/ypX4tE3IHMpU7m45KVaMXc AzWc3lWCABRApClbSWBfolPD4Zv76NKykKEbwrLUhe+tK3r5IozeVSTKNCQe2DK2 6ZG25x4wMAOtyp6OHHQp5ntiuSTDMJhhI4onlLmHtHVc67wbvrMYeCgK6TaVkYvx Wragj8otq5IKMKZEi/3yRdjDyPq/3aMnMQ0dexDnPct08fxcJvKSzGsMw36rYo9S 6bPZ6KKzWAd1bQ== X-ME-Sender: X-Sasl-enc: o+4NthynCgFMjNpXd0Vx3ha50Gy/EcPJHIAZguXOR1gQ 1502197997 Received: from xps.localnet (132.20.90.92.rev.sfr.net [92.90.20.132]) by mail.messagingengine.com (Postfix) with ESMTPA id A83847E4EA; Tue, 8 Aug 2017 09:13:17 -0400 (EDT) From: Thomas Monjalon To: Christian Ehrhardt , David Harton Cc: "Van Haaren, Harry" , dev@dpdk.org Date: Tue, 08 Aug 2017 15:13:04 +0200 Message-ID: <1971255.B48bYt7Eqt@xps> In-Reply-To: References: <20170807173914.36750-1-dharton@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ethdev: add return code to rte_eth_stats_reset() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Aug 2017 13:13:20 -0000 08/08/2017 13:03, Christian Ehrhardt: > On Tue, Aug 8, 2017 at 11:02 AM, Van Haaren, Harry < > harry.van.haaren@intel.com> wrote: > > > > > > Some devices do not support reset of eth stats. An application may > > > need to know not to clear shadow stats if the device cannot. > > > > > > rte_eth_stats_reset is updated to provide a return code to share > > > whether the device supports reset or not. > > > > > > Signed-off-by: David Harton > > > --- > > > > Hi, > > > > As far as I know changing the return type (void to int) of a function does > > *not* break ABI, but does "break" API as the application code should now > > check the return value. In theory the application could ignore the return > > value and current behavior is maintained. > > > > After discussing with Harry on IRC it turns out we both ended up checking > the same online sources > to verify our thoughts, like [1]. > > Given this and several other sources it seems to be as outlined above an > API but not ABI break. > I'm not an expert and this is mostly opinion, but my personal rule mostly > is: "if in doubt bump it". Anyway, the ABI will be broken (and bumped) again in 17.11. This patch will be accepted in 17.11.