From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89E37A09FD; Fri, 18 Dec 2020 12:30:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4DD73CAAB; Fri, 18 Dec 2020 12:30:03 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 551B7CAA7 for ; Fri, 18 Dec 2020 12:30:01 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E67565C00B5; Fri, 18 Dec 2020 06:29:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 18 Dec 2020 06:29:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= fCc87X8pBLu+U45kiBdNnjRS+NHVq2iZb3uBkw1aOPs=; b=FWYY0tYVDqA/RX0Y Fj0sxPi7umIoyjojP/HbzLuXLpDnXGVBxlYJYpUPsjSH4Zj7R+/JMX975d/Ohj1n qadMg+aPIQsR5HbHLcYZig8ozjXt08fLr15fZDSxk48/X2nByaCBXXAITD7Smm8P nxXRAcpf+CciTlNLTQPapVDUfRp/q3K/k6WMvS/+zhg2db5MUlUQzxGu/rTD7x5c Oa8YlLEXPIy6ppgpQO0vvtZ49E+IwyNawtoBEac96Qwq+AirIgh4HB2ZTe7pw62C zDI0ldD2bqh4XiFl1nsDMglbitsclNz0MQHh7ShlsEVVvTAkpv2Tll/5AvkbDeZ3 Gm/xmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=fCc87X8pBLu+U45kiBdNnjRS+NHVq2iZb3uBkw1aO Ps=; b=lUYn3YyEg5TvdJTtdAtR5Vhk1aE34fNkRN/Y88dSrtpBj15lv3GhW5FwR 6jYAGqBMbWJ6vSS4DyXl35UTOO1Wu5Q9y04nf3O/1FJCcrpFNOXuCkqTmQxYJGnV UMdPXrspkpBpMraJpRyD5CdQas864ZN31aT2M8juP89NVpbjjUbLbPEC0n3o90t1 G33gzxT7eCSDnE0tJLGwNEKMHGne0h3BOFfiTUS8XhryZ7gG70d+YMd2+Es4i1ZW jIT24BtwzoRNvBYHJDBPaBSLFzSrEQYe2Qc4KSsFL9DpUFTATaQegU3QiEWrMoG7 7a/65ikU0mhlR0nmC8G9qCcupjPxw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeliedgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrvddthedrudegfedruddtleenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (109.143.205.77.rev.sfr.net [77.205.143.109]) by mail.messagingengine.com (Postfix) with ESMTPA id 7CF9124005E; Fri, 18 Dec 2020 06:29:52 -0500 (EST) From: Thomas Monjalon To: Pallavi Kadam Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, talshn@nvidia.com, ferruh.yigit@intel.com, bruce.richardson@intel.com, beilei.xing@intel.com, jia.guo@intel.com Date: Fri, 18 Dec 2020 12:29:48 +0100 Message-ID: <1972131.Zv2h2cGNgz@thomas> In-Reply-To: <20201217225909.3580-2-pallavi.kadam@intel.com> References: <20201205011020.6276-1-pallavi.kadam@intel.com> <20201217225909.3580-1-pallavi.kadam@intel.com> <20201217225909.3580-2-pallavi.kadam@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal: add rte_random.c file on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/12/2020 23:59, Pallavi Kadam: > This file is required to compile and build i40e PMD on Windows. > Add rte_rand variable to export file. > > Redefine _m_prefetchw for Clang toolchain due to following error > with respect to conflicting types: > > FAILED: lib/76b5a35@@rte_eal@sta/librte_eal_common_rte_random.c.obj > clang @lib/76b5a35@@rte_eal@sta/librte_eal_common_rte_random.c.obj.rsp > In file included from ../lib/librte_eal/common/rte_random.c:13: > In file included from ..\lib/librte_eal/include\rte_eal.h:20: > In file included from ..\lib/librte_eal/include\rte_per_lcore.h:25: > In file included from ..\lib/librte_eal/windows/include\pthread.h:21: > In file included from ..\lib/librte_eal/windows/include\rte_windows.h:27: > In file included from C:\Program Files (x86)\Windows Kits\10\include\ > 10.0.18362.0\um\windows.h:171: > In file included from C:\Program Files (x86)\Windows Kits\10\include\ > 10.0.18362.0\shared\windef.h:24: > In file included from C:\Program Files (x86)\Windows Kits\10\include\ > 10.0.18362.0\shared\minwindef.h:182: > C:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\um\ > winnt.h:3324:1: error: conflicting types for '_m_prefetchw' > _m_prefetchw ( > ^ > C:\Program Files\LLVM\lib\clang\10.0.0\include\prfchwintrin.h:50:1: > note: previous definition is here > _m_prefetchw(void *__P) > ^ > 1 error generated. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > +#ifdef RTE_TOOLCHAIN_CLANG > +#undef _m_prefetchw > +#define _m_prefetchw __m_prefetchw > +#endif It deserves a comment explaining why __m_prefetchw is required.