DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Roger B. Melton" <rmelton@cisco.com>
Cc: dev@dpdk.org, Don Provan <dprovan@bivio.net>
Subject: Re: [dpdk-dev] Making rte_eal_pci_probe() in rte_eal_init() optional?
Date: Tue, 17 Nov 2015 16:46:54 +0100	[thread overview]
Message-ID: <1972675.qABnqcockr@xps13> (raw)
In-Reply-To: <564B3215.9020103@cisco.com>

2015-11-17 08:56, Roger B. Melton:
> Hi David,  in-line -Roger
> 
> On 11/16/15 4:46 AM, David Marchand wrote:
> > Hello Roger,
> >
> > On Sun, Nov 15, 2015 at 3:45 PM, Roger B. Melton <rmelton@cisco.com 
> > <mailto:rmelton@cisco.com>> wrote:
> >
> >     I like the "-b all" and "-w none" idea, but I think it might be
> >     complicated to implement it the way we would need it to work.  The
> >     existing -b and -w options  persist for the duration of the
> >     application, and we would need the "-b all"/"-w none" to persists
> >     only through rte_eal_init() time.  Otherwise our attempt to to
> >     attach a device at a later time would be blocked by the option.
> >
> > I agree, the black/white lists should only apply to initial scan.
> > I forgot about this problem ...
> > I had started some cleanup in the pci scan / attach code but this is 
> > too late for 2.2, I will post this in the next merge window.
> >
> >
> >     Wouldn't it be simpler to have an option to disable the
> >     rte_eal_init() time the probe.  Would that address the issue with
> >     VFIO, prevent automatically attaching to devices while permitting
> >     on demand attach?
> >
> >
> > I suppose we can do this yes (I think Thomas once proposed off-list an 
> > option like --no-pci-scan).
> > Do you think you can send a patch ?
> 
> What about --no-pci-init-probe?  I know it's long, but it is more 
> descriptive of it's purpose to disable only the init time pci probe.

Why not a "-b all"?
Making it work would also solve the case where you to scan only part of
the devices and initialize the blacklisted ones later.

  reply	other threads:[~2015-11-17 15:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 22:58 Don Provan
2015-11-13 23:03 ` Jan Viktorin
2015-11-14 15:55 ` Roger B. Melton
2015-11-14 17:51   ` David Marchand
2015-11-15 14:45     ` Roger B. Melton
2015-11-16  9:46       ` David Marchand
2015-11-17 13:56         ` Roger B. Melton
2015-11-17 15:46           ` Thomas Monjalon [this message]
2015-11-18 22:13             ` Roger B. Melton
2015-11-21 12:54               ` Roger B. Melton
  -- strict thread matches above, loose matches on Subject: below --
2015-11-12 22:43 Roger B Melton
2015-11-13  8:49 ` David Marchand
2015-11-13 12:07   ` Roger B. Melton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1972675.qABnqcockr@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=dprovan@bivio.net \
    --cc=rmelton@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).