From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 8C9732E8D for ; Tue, 17 Nov 2015 16:48:08 +0100 (CET) Received: by wmdw130 with SMTP id w130so160785973wmd.0 for ; Tue, 17 Nov 2015 07:48:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=zdRVzcfl8Abf/LgHZ5kxLQKFLTs5UH5KRudVWXTRRQ8=; b=NC8PGRjVccQWf02reiII7nsJdas20iLlkzA4CDBfyRb4XhmIwO/Z1NdT1YBr7iMd7i Bg1vF8qsCtNS0ietNM0Ejv6igPi4ozyWytX196Exy7m6xwg6l0S4TBXSQlN/hB6gKZsW 1Po/cgxMqHtL7hQxJiOXmBZE37HYao5PTpMTdptPETYI6V+KoaQcZnZkWkyJQF3sLQ9H U99ydxZJGfA8omNFE+syyvgGiR6PDbKcd97fs4gzA9L8rfCzdb09im3hQspGg++Rs5Tj UUJRRTW1Lpp4t7xFAO2PCc+6e3Y5ylb8nXqRxxiYgKkUYrch0XkoryC5RxW52niT+qIo 8Jwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=zdRVzcfl8Abf/LgHZ5kxLQKFLTs5UH5KRudVWXTRRQ8=; b=TvflaW/9HQyYgYAimYKm7ACtSiuvA/MnpPhniwWrkvxeefEiG0cQJ9ALA6XhLXa7bd owVn7AolnPci2BU2ZJvQtLPDtaCsxjoRprZUJxO/gXyVhB5zGpq+g76mQEV5Ikgstf12 qrqFcimetu4PARjyWVBu1Z5CyPiU6ZSLtkEZqZCegmEuzm7fWwNuwKBXkAz6t9g1yA7/ tyaYsuRYMkXGJSBvi7E/pFAyFQ1kW/EO1djeCWpP7/ga8dBMOXVFPBkXpRjvaye36vu5 xXFTgsgSOupTNijA+mPichIlHXmP10fHtcexuvIIxVQxncHgBvM2AkQNBW8m8FEJuC3J 4RuA== X-Gm-Message-State: ALoCoQngb0FL8EcZ45xKiGjRvj2eLRrgiSJ9hj4crEkHoySbHZLLuswbn3MwMr4E28TsFyDae15z X-Received: by 10.194.62.234 with SMTP id b10mr163435wjs.167.1447775288376; Tue, 17 Nov 2015 07:48:08 -0800 (PST) Received: from xps13.localnet (napsach001.hosting-cea.net. [192.54.209.32]) by smtp.gmail.com with ESMTPSA id uq3sm13984064wjc.10.2015.11.17.07.48.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Nov 2015 07:48:07 -0800 (PST) From: Thomas Monjalon To: "Roger B. Melton" Date: Tue, 17 Nov 2015 16:46:54 +0100 Message-ID: <1972675.qABnqcockr@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <564B3215.9020103@cisco.com> References: <564B3215.9020103@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Don Provan Subject: Re: [dpdk-dev] Making rte_eal_pci_probe() in rte_eal_init() optional? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2015 15:48:08 -0000 2015-11-17 08:56, Roger B. Melton: > Hi David, in-line -Roger > > On 11/16/15 4:46 AM, David Marchand wrote: > > Hello Roger, > > > > On Sun, Nov 15, 2015 at 3:45 PM, Roger B. Melton > > wrote: > > > > I like the "-b all" and "-w none" idea, but I think it might be > > complicated to implement it the way we would need it to work. The > > existing -b and -w options persist for the duration of the > > application, and we would need the "-b all"/"-w none" to persists > > only through rte_eal_init() time. Otherwise our attempt to to > > attach a device at a later time would be blocked by the option. > > > > I agree, the black/white lists should only apply to initial scan. > > I forgot about this problem ... > > I had started some cleanup in the pci scan / attach code but this is > > too late for 2.2, I will post this in the next merge window. > > > > > > Wouldn't it be simpler to have an option to disable the > > rte_eal_init() time the probe. Would that address the issue with > > VFIO, prevent automatically attaching to devices while permitting > > on demand attach? > > > > > > I suppose we can do this yes (I think Thomas once proposed off-list an > > option like --no-pci-scan). > > Do you think you can send a patch ? > > What about --no-pci-init-probe? I know it's long, but it is more > descriptive of it's purpose to disable only the init time pci probe. Why not a "-b all"? Making it work would also solve the case where you to scan only part of the devices and initialize the blacklisted ones later.