DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dpdk-dev <dev@dpdk.org>
Cc: JP Lee <jongpil.lee@broadcom.com>,
	Kovacevic Marko <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] doc: update bnxt guide
Date: Tue, 19 May 2020 09:15:57 +0100	[thread overview]
Message-ID: <19772799-f168-dfd2-24db-1eee627e1a68@intel.com> (raw)
In-Reply-To: <CACZ4nhs0gqeydkjs79X2iGQOENtNuhGeotR1dvybJ5XjmMe69w@mail.gmail.com>

On 5/18/2020 11:04 PM, Ajit Khaparde wrote:
> 
> 
> On Mon, May 18, 2020 at 10:58 AM Ajit Khaparde <ajit.khaparde@broadcom.com
> <mailto:ajit.khaparde@broadcom.com>> wrote:
> 
>         - Update list of supported adapters.
>         - Update list of supported features.
>         - Add some details to describe the features.
>         - Remove obsolete limitations.
>         - Fix and update links.
> 
>     Signed-off-by: JP Lee <jongpil.lee@broadcom.com
>     <mailto:jongpil.lee@broadcom.com>>
>     Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com
>     <mailto:ajit.khaparde@broadcom.com>>
>     Acked-by: Kovacevic Marko <marko.kovacevic@intel.com
>     <mailto:marko.kovacevic@intel.com>>
>     ---
>     v1->v2: Some lines were too long in v1. Made then shorter. Checked for typos.
>     v2->v3: Removed list of extended stats.
>     v3->v4: Removed an irrelevant line.
> 
> 
> Patch applied to dpdk-next-net-brcm. Thanks
> 
>     ---
>      doc/guides/nics/bnxt.rst | 893 +++++++++++++++++++++++++++++++++------
>      1 file changed, 763 insertions(+), 130 deletions(-)
> 
>     diff --git a/doc/guides/nics/bnxt.rst b/doc/guides/nics/bnxt.rst
>     index 434ba9d6c..3aad7ea4a 100644
>     --- a/doc/guides/nics/bnxt.rst
>     +++ b/doc/guides/nics/bnxt.rst
>     @@ -1,138 +1,771 @@
>     -..  SPDX-License-Identifier: BSD-3-Clause
>     -    Copyright 2016-2019 Broadcom
>     +.. SPDX-License-Identifier: BSD-3-Clause
>     +   Copyright 2020 Broadcom Inc.
> 
>      BNXT Poll Mode Driver
>      =====================
> 
>     -The BNXT PMD (**librte_pmd_bnxt**) implements support for adapters based on
>     -Ethernet controllers and SoCs belonging to the **Broadcom BCM5730X NetXtreme-C®
>     -Family of Ethernet Network Controllers**, the **Broadcom BCM574XX/BCM575XX
>     -NetXtreme-E® Family of Ethernet Network Controllers**, the **Broadcom BCM588XX
>     -Stingray Family of SmartNIC Adapters**, and the **Broadcom StrataGX® BCM5871X
>     -Series of Communications Processors**.  A complete list with links to reference
>     -material is included below.
>     +The Broadcom BNXT PMD (Poll Mode Driver, librte_pmd_bnxt) implements
>     support for adapters based on Ethernet controllers and SoCs belonging to the
>     Broadcom BCM574XX/BCM575XX NetXtreme-E® Family of Ethernet Network
>     Controllers, the Broadcom BCM588XX Stingray Family of Smart NIC Adapters,
>     and the Broadcom StrataGX® BCM5873X Series of Communications Processors.
> 

Hi Ajit,

Both Marko's and my comment to keep .rst line length short seems not addressed.
This one long line makes the .rst file hard to read. Can you please fix this for
all document?

Thanks,
ferruh


  reply	other threads:[~2020-05-19  8:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 22:03 [dpdk-dev] [PATCH] " Ajit Khaparde
2020-05-05 16:58 ` Ajit Khaparde
2020-05-06  8:57 ` Ferruh Yigit
2020-05-06 16:09   ` Ajit Khaparde
2020-05-13  9:08     ` Ferruh Yigit
2020-05-14 10:39 ` Kovacevic, Marko
2020-05-15 21:56   ` [dpdk-dev] [PATCH v2] " Ajit Khaparde
2020-05-18  9:34     ` Ferruh Yigit
2020-05-18 17:38       ` [dpdk-dev] [PATCH v3] " Ajit Khaparde
2020-05-18 17:58       ` [dpdk-dev] [PATCH v4] " Ajit Khaparde
2020-05-18 22:04         ` Ajit Khaparde
2020-05-19  8:15           ` Ferruh Yigit [this message]
2020-05-20 20:03             ` [dpdk-dev] [PATCH v5] " Ajit Khaparde
2020-05-21  1:16               ` Ajit Khaparde
2020-05-21 13:51                 ` Ferruh Yigit
2020-05-23  3:53                   ` Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19772799-f168-dfd2-24db-1eee627e1a68@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=jongpil.lee@broadcom.com \
    --cc=marko.kovacevic@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).