Re: [PATCH] app/procinfo: show all non-owned ports

[Thomas Monjalon <thomas@monjalon.net>]

23/05/2022 18:10, Subendu Santra:
> Sure. Will add a sentence about the issue which is getting fixed.
> However, I have already added Fixes: 1dd6cffb6571 in the patch.

Sorry I missed it.

> Is there anything else that needs to be done apart from this w.r.to
> "Fixes:" comment?

No that's fine, thanks.

> 
> Regards,
> Subendu.
> 
> 
> On Mon, May 23, 2022 at 8:12 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 23/05/2022 12:53, Subendu Santra:
> > > Hi Reshma, Thomas,
> > >
> > > What do you think about this patch?
> >
> > It looks to be a fix, right?
> > Please add a sentence about the previous behaviour,
> > explaining what is fixed.
> >
> > Ideally you should show the commit doing the mistake
> > with the syntax "Fixes:" as in other commits of this tree.
> >
> > Thanks
> >
> >
> > > On Tue, May 10, 2022 at 6:52 PM Subendu Santra <subendu@arista.com> wrote:
> > > >
> > > > Show all non-owned ports when no port mask is specified
> > > >
> > > > Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned
> > > > ports")
> > > > Cc: stephen@networkplumber.org
> > > >
> > > > Signed-off-by: Subendu Santra <subendu@arista.com>
> > > > ---
> > > >  app/proc-info/main.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> > > > index 56070a3317..2be24b584e 100644
> > > > --- a/app/proc-info/main.c
> > > > +++ b/app/proc-info/main.c
> > > > @@ -1504,10 +1504,10 @@ main(int argc, char **argv)
> > > >         if (nb_ports == 0)
> > > >                 rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
> > > >
> > > > -       /* If no port mask was specified, then show non-owned ports */
> > > > +       /* If no port mask was specified, then show all non-owned ports */
> > > >         if (enabled_port_mask == 0) {
> > > >                 RTE_ETH_FOREACH_DEV(i)
> > > > -                       enabled_port_mask = 1ul << i;
> > > > +                       enabled_port_mask |= (1ul << i);
> > > >         }
> > > >
> > > >         for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
> > > > --
> > > > 2.28.0
> > > >
> > >
> >
> >
> >
> >
> >
>