From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 660D429CB for ; Tue, 23 Feb 2016 21:08:47 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id g62so342241wme.0 for ; Tue, 23 Feb 2016 12:08:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=HK+Pl+O7/w3o15ZYZhin03DjDJjrKkSkm8HS9R3Eb8I=; b=MynCaYL5WfKImAIzc9D6wEAdsa+tJ6xSUbAxQ8+qqNTKTH3mdMLqU+1rDgPTzC42hC XVm4sFxTUeA9Iwo2Nphi6RfxQ+SBJEvjn5uc+1UveqizSrvmcwItoEZoHsZjOnCsYXAx EbAqIWTalgbu8jltAz5/xb8r1ogwZ/4W2XqWW2ljdIAiAsLUtL7SUJ3dt55/E4ufpyvZ mpwqTb1JTVFxjMGWmzFjdFbu1P81rdkTI0sHksMMMSJRvyuW9jrY+Gq3M6suuReBUP3k FPHstVC2sB6xJptFJtCehCR7JbCWo1NXektZGgFJ/c8TNVTGkFOTDFAXTl753GQZT1uV j03g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=HK+Pl+O7/w3o15ZYZhin03DjDJjrKkSkm8HS9R3Eb8I=; b=FnV/Zk3MJGXh/w1/n5RIsAMSlYEbYDqRSbKFOn/wGfS0tN6H5lMMF8O7lw0Xjzn1qW xP9r6J2kEeCKlYlwhtrRUGXAXuZOV5TosgAEUUbU3AWhBMDZD8UWVxC1hVyhPJEqo1H5 H0PwQEYW74wEiAXsf1Lj1IiZqvdUga90hlc2MO+kQoro6bun39P1+rFYaVIWNgJh03/c xvjj3yEo54e6iFMTDUoN+48Tp/dpv9f03N5vRERj1qpwLCbbD3GSg+kiqDTM5RuV3lqb x0AQ/68gzDWkDtdIBw0tN/iLpQilG7PEfvkb9PHYrBAEAQvszpA0+feH81iZmW0jlamE 1LOA== X-Gm-Message-State: AG10YOSMBsZC7XMRmAZX6ohw0olSzBAErRdOZpyLuT33jho393sjKpjlNQjoMLS1F5eQZiJm X-Received: by 10.194.248.163 with SMTP id yn3mr34718362wjc.179.1456258127245; Tue, 23 Feb 2016 12:08:47 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id x66sm27716873wmb.20.2016.02.23.12.08.45 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Feb 2016 12:08:46 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Tue, 23 Feb 2016 21:07:12 +0100 Message-ID: <1979393.TOkl0U0KRM@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <079fa1cfc3550c8147ea8b137fa1bc0f34d051dc.1448375477.git.pmatilai@redhat.com> References: <079fa1cfc3550c8147ea8b137fa1bc0f34d051dc.1448375477.git.pmatilai@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix the combined library problems by replacing it with a linker script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2016 20:08:47 -0000 Hi, I'm reviving this old thread. My understanding is that everybody prefer the linker script than the current combined library which had neither symbol versioning nor library dependency informations. Comments below: 2015-11-24 16:31, Panu Matilainen: > The physically linked-together combined library has been an increasing > source of problems, as was predicted when library and symbol versioning > was introduced. Replace the complex and fragile construction with a > simple linker script which achieves the same without all the problems, > remove the related kludges from eg mlx drivers. > > Since creating the linker script is practically zero cost, remove the > config option and just create it always. [...] > --- /dev/null > +++ b/mk/rte.combinedlib.mk > @@ -0,0 +1,57 @@ > +# BSD LICENSE > +# > +# Copyright(c) 2010-2015 Intel Corporation. All rights reserved. > +# All rights reserved. > +# > +# Redistribution and use in source and binary forms, with or without > +# modification, are permitted provided that the following conditions > +# are met: > +# > +# * Redistributions of source code must retain the above copyright > +# notice, this list of conditions and the following disclaimer. > +# * Redistributions in binary form must reproduce the above copyright > +# notice, this list of conditions and the following disclaimer in > +# the documentation and/or other materials provided with the > +# distribution. > +# * Neither the name of Intel Corporation nor the names of its > +# contributors may be used to endorse or promote products derived > +# from this software without specific prior written permission. Why this header, Panu? I think you should write your own copyright, and assume the linker script ;) It needs to be rebased and some docs comments must be removed or updated. I'll send a v2.