From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6314AA034F; Mon, 11 Oct 2021 10:28:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CCB3410DA; Mon, 11 Oct 2021 10:28:22 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 4693540E01 for ; Mon, 11 Oct 2021 10:28:21 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 96497580E71; Mon, 11 Oct 2021 04:28:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 11 Oct 2021 04:28:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 0nJqlX6YMzjIKUP2wRYysfXrbM9aHA6kMlvgsKMlT0E=; b=C8Jwcw3Rb36/VCzP Ma7e5nFMu2utSfgzf79fsNmgso00LIqcBa75zFFr91R/DYyyAtt8eqk/UlCF0lis mxGOh1AlN5/aElt5gqx+rpF0e/ciAkrO5xvTxjJ9cJG3mLr0qCJeQlhEvUvb8oTJ ZQqP0vvt/XGorjXvGd2eUvqYCAm08YLFuDjy4WRWZ3t13+W1S4p/6hvoEpL7l3Zx e2pGv7dnyPhtQ+yQIdcw9KUp4VlWedCUaUDwdeAhkw+h4pIg9DzicrJ4eWM4XHlk vlS7+65GpAQqCKiuPfL6aQHvRhWe3bmjf/GjO0XclXdtYDHAwraIrMW+pMkYQTYt 7tWcuw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=0nJqlX6YMzjIKUP2wRYysfXrbM9aHA6kMlvgsKMlT 0E=; b=bJJX20OXnoYuSeKLfqruW5n+BU2z+h6BsFlQ0N6pvn81T5aDvthKK5GUF 1dWpQ+8FFddAGdXZXxnzA/L4BCz4fUEXFgDg+Rk8nZUHIDJgYg2osmJ3K2+e1eS7 O9c446tDj+A1v3353daspVYWQ6UTOTH3JAB54faK0PGAnFXMnomxpCDWSvslrdG+ MhOeS8V+4nJ1w9zhdi9N6r3ekRZp7MaiwnZdbzP7OjeGZ08ku1prvkOc0UyMZVHi F1w/7RwXx702yg4Mj0Boe0eH9Rilp65ylRhmVPrvW6LmBzrSqMjsPTMoRaOpiB2F 9i2WlMNtKV528iVG4c9F0xgOrHFjw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddtiecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrg htthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueeiiedv ffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Oct 2021 04:28:04 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Xueming Li Cc: dev@dpdk.org, Andrew Rybchenko , Singh Aman Deep , Ajit Khaparde , Somnath Kotur , Igor Russkikh , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Chas Williams , "Min Hu (Connor)" , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Andrew Boyer , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , Long Li , Martin Spinler , Heinrich Kuhn , Jiawen Wu , Tetsuya Mukawa , Harman Kalra , Jerin Jacob , Nalla Pradeep , Radha Mohan Chintakuntla , Veerasenareddy Burru , Devendra Singh Rawat , Keith Wiles , Maciej Czekaj , Jian Wang , Maxime Coquelin , Chenbo Xia , Yong Wang Date: Mon, 11 Oct 2021 10:28:02 +0200 Message-ID: <1980368.fPBH8iPQn9@thomas> In-Reply-To: <20211006111822.437298-3-xuemingl@nvidia.com> References: <20210727034134.20556-1-xuemingl@nvidia.com> <20211006111822.437298-1-xuemingl@nvidia.com> <20211006111822.437298-3-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 2/2] ethdev: change queue release callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/10/2021 13:18, Xueming Li: > --- a/drivers/net/szedata2/rte_eth_szedata2.c > +++ b/drivers/net/szedata2/rte_eth_szedata2.c > static void > -eth_tx_queue_release(void *q) > +eth_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid) > { > - struct szedata2_tx_queue *txq = (struct szedata2_tx_queue *)q; > + struct szedata2_tx_queue *txq = dev->data->tx_queues[qid]; > > if (txq != NULL) { > if (txq->sze != NULL) > szedata_close(txq->sze); > rte_free(txq); > + dev->data->tx_queues[i] = NULL; > } > } Compilation is broken. I will do following change in the patch on main: - dev->data->tx_queues[i] = NULL; + dev->data->tx_queues[qid] = NULL;