DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: jingjing.wu@intel.com, Junfeng Guo <junfeng.guo@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, xingguang.he@intel.com,
	kevin.laatz@intel.com, bruce.richardson@intel.com
Subject: Re: [PATCH] examples/ntb: remove redundant logic for dev close
Date: Wed, 28 Jun 2023 02:12:12 +0200	[thread overview]
Message-ID: <1980494.zToM8qfIzz@thomas> (raw)
In-Reply-To: <20230614051423.176572-1-junfeng.guo@intel.com>

14/06/2023 07:14, Junfeng Guo:
> During EAL cleanup stage, all bus devices are cleaned up properly.
> Based on this, there is no need to do extra device close process,
> which may call the dev ops '*dev->dev_ops->dev_close' twice.
> 
> If this dev ops for ntb was called twice, the interrupt handle for
> EAL will be disabled twice and will lead to error for the seconde
> time. Like this: "EAL: Error disabling MSI-X interrupts for fd xx"

You should fix ntb to not disable interrupt twice.



  parent reply	other threads:[~2023-06-28  0:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14  5:14 Junfeng Guo
2023-06-15  8:28 ` Ling, WeiX
2023-06-28  0:12 ` Thomas Monjalon [this message]
2023-06-28  2:19   ` Guo, Junfeng
2023-06-28  2:37     ` Guo, Junfeng
2023-06-28  7:53       ` Thomas Monjalon
2023-06-28  8:08         ` Guo, Junfeng
2023-06-28  9:12 ` [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops Junfeng Guo
2023-06-29  8:03   ` Ling, WeiX
2023-07-03  6:53   ` Wu, Jingjing
2023-07-03 15:44     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1980494.zToM8qfIzz@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=junfeng.guo@intel.com \
    --cc=kevin.laatz@intel.com \
    --cc=stable@dpdk.org \
    --cc=xingguang.he@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).