From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E19042D76; Wed, 28 Jun 2023 02:12:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD73C42D0C; Wed, 28 Jun 2023 02:12:17 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 5BF2340151; Wed, 28 Jun 2023 02:12:16 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id E25F43200936; Tue, 27 Jun 2023 20:12:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 27 Jun 2023 20:12:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687911134; x=1687997534; bh=fbbwXJC6O3+8PJyOUoeEFsKKB3CGS+CkcJd j6elyykk=; b=ffmuVtuTdsCui02Q4EhXvoSLs3FSfBlCVtPktNp6JsYwLCytUeO kZlH52gAvu4jPC8Zrx1jARcBSH7SSbuzb+jZxtDwXP/imbwqL0vpwWS+FQ0c5ADX E2txcHWPvcV7Nf3lUlOiihxfmid923CvunxlSsMV3d5jEPcbCY2PJRoc1PaG5Dwo 6yWhKHTt3GpVp/9jQu/iIb5M1XMMI/CGW+6f2uJ9tGiYONq2v4dFiKM06mPnOdfK eqEjYbGiBlSZBRiBfi2HnDNoMFGZRJZmcZIR7oeP4jT+PI0Bhz3EmrZR8uXC3rlL 4qSSuoB+Dw7H9iG/VVe0SxCc+A9G8iblEYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687911134; x=1687997534; bh=fbbwXJC6O3+8PJyOUoeEFsKKB3CGS+CkcJd j6elyykk=; b=S6MxoSpeptmQZxHnFEjp9oqSDX1lxCcZPuHAH1QgwwoquWwmru0 E7wc3pTTaxSXVX4RcdsJD+Ke7VRZZyvrEkfrjc3vpFreLqJJ3EPlc7IitzhWAszA XB+vndZY7hOg3UFprMaE5AEMgDPikxc9Hdug/j99CWKNsaUQ5ygMqVw06voR6u/T nNUtkrMPxVJCkY+beKaje0HwxcpMfhqz1UV6QetJZngOubwPGu1NgfHXmtB5xxHu QATHkpHQ4vjU69BR1ZEwLZIkWes+jREjyE8cZTOg+XdAtBaK4ICSEj7znYQt/9rI aY1cDj9BUDOW0xZ2h2LD9dNCrlmJ/PCjsaQ== X-ME-Sender: <xms:3nqbZHFaWsGmsYGpKzflkypkekG6E9BjRTAlvdbJ_w8FV-nYEYVLYA> <xme:3nqbZEUk3CZmgvZkG32D6Ag1O4vZkWOFw8qAnUG9jk5Sd41RAPJ48o5isXa5MNk_a sGDZUwfqRsGQYgwmQ> X-ME-Received: <xmr:3nqbZJLHTZFUPU628c92ZDmp7b3KQq-Yi6BN3oMpEPZTEaf-WF-bEiszWeBMGmu-ZZXp-_wwHhV0iCfvQLa3EW40Dg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtddugdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:3nqbZFGR5podD3is7U50IfEaB1PGOOvVM_RQMR39SEYCI3RFBeM8OQ> <xmx:3nqbZNVpqouTdf9odpn4L9bsnjBSCCttiWnKIPz3YYylNNYuhAWAXw> <xmx:3nqbZAMK51k6vUaNA1FKL7-ElyZ2xwPqjQ8XtmAQZ0pSsQzXEu2fFA> <xmx:3nqbZLcRg3epSb0xcLnu4Nhf1yfT6ApYfH5EF_b45zrevjt6Tj8YtA> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Jun 2023 20:12:13 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: jingjing.wu@intel.com, Junfeng Guo <junfeng.guo@intel.com> Cc: dev@dpdk.org, stable@dpdk.org, xingguang.he@intel.com, kevin.laatz@intel.com, bruce.richardson@intel.com Subject: Re: [PATCH] examples/ntb: remove redundant logic for dev close Date: Wed, 28 Jun 2023 02:12:12 +0200 Message-ID: <1980494.zToM8qfIzz@thomas> In-Reply-To: <20230614051423.176572-1-junfeng.guo@intel.com> References: <20230614051423.176572-1-junfeng.guo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 14/06/2023 07:14, Junfeng Guo: > During EAL cleanup stage, all bus devices are cleaned up properly. > Based on this, there is no need to do extra device close process, > which may call the dev ops '*dev->dev_ops->dev_close' twice. > > If this dev ops for ntb was called twice, the interrupt handle for > EAL will be disabled twice and will lead to error for the seconde > time. Like this: "EAL: Error disabling MSI-X interrupts for fd xx" You should fix ntb to not disable interrupt twice.