From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 5A098D586 for ; Wed, 18 Jan 2017 08:31:04 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id r126so233497487wmr.0 for ; Tue, 17 Jan 2017 23:31:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=IQlvSIuOOraBxq06fNbeSRppsgMBQ5+hvGjAb4MJgxU=; b=bBOAZIoufzfylkEX+UfRQl14LbDk+O85B61YBmimHVACH75sK5+460Pq4wNf50LPP6 Y4MK3p+ANquQCrb4s8GQXycz5wE67rOAuYAmBNHoRTnaJRgu0mr8DglrZ5WB8i7vNqqL UK6R5wy4mjJy+ZzI4S/lV7DyvSzp7P4SWQRHuY+KYOCzgNWS82c/34RYU7BF2s3AYlLl YtRqBSJ2G+c42oz2LDrSWinAJJvzrvJbCz5TIzmzC8/Lisx+zMbB7hJ1jPuEqK7411Y8 AEsAS+2Cg2hWmLvDrrVEklhH+jNuHiJ5DPorEOWBg2LfvxLlVO5ONmZC8PHLn5h9lKh0 u7bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=IQlvSIuOOraBxq06fNbeSRppsgMBQ5+hvGjAb4MJgxU=; b=mCYvSfSw4nwx1kqKT8qE3DipmUKd8dgE+sfwj3w1zjAONBN7kw44VTaHwa35abVyji /yiUuaxWkPJFNcjlOPcGrMiFhHGKCLvRbq4YO/gzdjxyyp6twPUdRhu5siOb8+/DmXVo H9K39GJcojIqIJj+NY1Li/CEsq6y/dFwXGSWPZ/eMDxAtqxqG5MNJM5WH6WBgk/4NwLy +ibzcye/oNi+zrDufHFRrnMh8h18M3O4TxlDqs2J6+1gSQx1H9VCSMFj6iuJm5nv4auP 0vWVM7C1B6YLO5hkO4KMuQ9pg05aqX94SXf5R+BwXequnApLA/bbcoF2OoSd+mZvPAmt 7wOg== X-Gm-Message-State: AIkVDXJ4aZypKVqS7Y8RxbxSAfhP7XT0fnoX+UAeK2mYTLxutXuJKVEDoVpf95XQZLx+r67t X-Received: by 10.28.168.11 with SMTP id r11mr18325247wme.16.1484724663686; Tue, 17 Jan 2017 23:31:03 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id d64sm43263761wmh.3.2017.01.17.23.31.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jan 2017 23:31:02 -0800 (PST) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org Date: Wed, 18 Jan 2017 08:31:01 +0100 Message-ID: <1982590.t5Omiyb9eb@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com> <6385545.1JoApMrEe4@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 3/9] pci: split match and probe function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 07:31:04 -0000 2017-01-18 06:17, Shreyansh Jain: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2017-01-17 19:07, Shreyansh Jain: > > > +static int > > > +rte_eal_pci_detach_dev(struct rte_pci_driver *dr, > > > + struct rte_pci_device *dev) > > > +{ > > > + int ret; > > > + struct rte_pci_addr *loc; > > > + > > > + if ((dr == NULL) || (dev == NULL)) > > > + return -EINVAL; > > > + > > > + ret = rte_pci_match(dr, dev); > > > > I do not understand this function. > > The driver should be known by the device at this stage. > > Why specifying a driver as parameter? > > > > I know it is not new in this series, but > > pci_detach_all_drivers(struct rte_pci_device *dev) makes no sense to me. > > From what I understand, pci_detach_all_drivers is simply a wrapper over the PCI driver list, calling rte_eal_pci_detach_dev for each driver. Considering that all it does is iterate, it is not functionally required. > > But, let me clarify one more thing: There is a possibility that rte_pci_device->pci_driver be directly used in case of detach rather than searching for a driver. This is assuming that before 'detach', a pci_device would link to a valid pci_driver. Is there some caveat in this assumption? I would say it it always true. But seeing this code existing makes me hesitates. I suggest to go with this assumption for RC1 and remove this loop.