From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enable RSS support for i40e
Date: Wed, 27 Aug 2014 17:36:39 +0200 [thread overview]
Message-ID: <1982600.IVFo8mPmpM@xps13> (raw)
In-Reply-To: <1405651521-14545-3-git-send-email-helin.zhang@intel.com>
2014-07-18 10:45, Helin Zhang:
> i40e can support RSS no matter if SR-IOV is enabled or not, while
> ixgbe/igb can not support RSS if it is SR-IOV. Code changes are
> needed to support i40e RSS if SR-IOV is enabled.
[...]
> - /* In SR-IOV mode, RSS mode is not available */
> - if (port->dcb_flag == 0 && port->dev_info.max_vfs == 0) {
> + /**
> + * For i40e, RSS is always available.
> + * For non-i40e, RSS is available in non-SRIOV mode,
> + * according to datasheet.
> + */
> + if (port->dcb_flag == 0 &&
> + ((port->dev_info.max_vfs == 0) ||
> + (!strcmp(port->dev_info.driver_name,
> + "rte_i40e_pmd")) ||
> + (!strcmp(port->dev_info.driver_name,
> + "rte_i40evf_pmd")))) {
This kind of knowledge should be coded in the drivers.
Application writer doesn't have to read the datasheet to use the drivers.
I think returning an error in the driver could be enough to handle it at
application level.
Thanks
--
Thomas
next prev parent reply other threads:[~2014-08-27 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 2:45 [dpdk-dev] [PATCH 0/3] add i40e RSS support in VF Helin Zhang
2014-07-18 2:45 ` [dpdk-dev] [PATCH 1/3] i40evf: add " Helin Zhang
2014-07-18 2:45 ` [dpdk-dev] [PATCH 2/3] app/testpmd: enable RSS support for i40e Helin Zhang
2014-08-27 15:36 ` Thomas Monjalon [this message]
2014-07-18 2:45 ` [dpdk-dev] [PATCH 3/3] ethdev: improvements for some macro definition in head file Helin Zhang
2014-08-27 15:42 ` Thomas Monjalon
2014-07-31 1:55 ` [dpdk-dev] [PATCH 0/3] add i40e RSS support in VF Zhan, Zhaochen
2014-08-20 7:07 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1982600.IVFo8mPmpM@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).