From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174]) by dpdk.org (Postfix) with ESMTP id 63B84B377 for ; Wed, 27 Aug 2014 17:32:44 +0200 (CEST) Received: by mail-we0-f174.google.com with SMTP id x48so402080wes.5 for ; Wed, 27 Aug 2014 08:36:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=JnLjM6iWO3XlE0JsPYhgAxt9soymYAjdY6+z63THm/8=; b=gSNZo2uC6k0f5HHgLJZ3n+vNXyzyPSo6RcVjocMfUiDOMUO3UoYjJhSyYeDI98bGTk dpcViSVLMS8trplz3DZFjljEkOB1mgFa5ERtQmohIIY6wToWiSr5JeCXUD6wMlIk6Yw9 PAaH9YmFwN1UpLGKnQHwGAcoO6mKMQ9vo/Iw0FYSDY2/TpOu43bDS80RVsIau+0e9S0y IMIjwvmR29MGqpYPYt0n9Wg0MOYhRQPoZJ2uBoqcJvKrPiZQ369MPwweEG8fiQ6nvqIi rWOs+FaJoNW6kh8vzFeeXLtkICSOJ48e94VdWjmYNQuDzXEtWU0SwfexME5NTCrlSqYF gRzA== X-Gm-Message-State: ALoCoQmincjLaya3JQvF8EMPlfbHr7fqElG9zawgBBZqv61Xfj9pxWSSUDIuMIgm3HzmoDDaCV+C X-Received: by 10.180.73.139 with SMTP id l11mr29343938wiv.30.1409153807446; Wed, 27 Aug 2014 08:36:47 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id j7sm24985521wia.9.2014.08.27.08.36.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Aug 2014 08:36:46 -0700 (PDT) From: Thomas Monjalon To: Helin Zhang Date: Wed, 27 Aug 2014 17:36:39 +0200 Message-ID: <1982600.IVFo8mPmpM@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1405651521-14545-3-git-send-email-helin.zhang@intel.com> References: <1405651521-14545-1-git-send-email-helin.zhang@intel.com> <1405651521-14545-3-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enable RSS support for i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2014 15:32:44 -0000 2014-07-18 10:45, Helin Zhang: > i40e can support RSS no matter if SR-IOV is enabled or not, while > ixgbe/igb can not support RSS if it is SR-IOV. Code changes are > needed to support i40e RSS if SR-IOV is enabled. [...] > - /* In SR-IOV mode, RSS mode is not available */ > - if (port->dcb_flag == 0 && port->dev_info.max_vfs == 0) { > + /** > + * For i40e, RSS is always available. > + * For non-i40e, RSS is available in non-SRIOV mode, > + * according to datasheet. > + */ > + if (port->dcb_flag == 0 && > + ((port->dev_info.max_vfs == 0) || > + (!strcmp(port->dev_info.driver_name, > + "rte_i40e_pmd")) || > + (!strcmp(port->dev_info.driver_name, > + "rte_i40evf_pmd")))) { This kind of knowledge should be coded in the drivers. Application writer doesn't have to read the datasheet to use the drivers. I think returning an error in the driver could be enough to handle it at application level. Thanks -- Thomas