From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id 5DC1936E for ; Wed, 14 May 2014 14:54:39 +0200 (CEST) Received: by mail-we0-f175.google.com with SMTP id t61so1845109wes.6 for ; Wed, 14 May 2014 05:54:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=W77qQIZzLgM3TORRRqAETGfqfF1cHgcmZrr01JvAIGQ=; b=KeVSUnMGbJQrpGOBRO27HbD0L5d4Pr+G2BdYEcZ+49Lydh68HZp1GUB2ENgfJf+wg7 nB0rZTKLR0j+Glm+NkywyJSIZGif32WErV30SImF8x6UCPaQQouGCMWrqPMTJaPp/h68 CtFO9WnybQNIJLjqEGgcG2JGXxKTrYmueeQxOcQp/ciCkj0E3LIHVMvGf8P8YcWodtjj SjAN/ujEpPJkOnSFKYrb7oBLC9aLRC0WzhPotgZQyqd5dzE7kEn6w3gUpeRfXDbbr5e1 vFbx9Vvb4pmn2J81cYMaz4+1l7KDcwxY8UltxzStrH+dsPqNOkJJ1OdRbGvCueQ22wXS T13A== X-Gm-Message-State: ALoCoQmV1HBP4Cr/K9BhN5I4H4z6d//bdNJx/xpwe1s/LHjJzkewHZy/4VRzN0NcRJo9GefgRUn4 X-Received: by 10.180.86.74 with SMTP id n10mr3325557wiz.55.1400072086866; Wed, 14 May 2014 05:54:46 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id em5sm3852812wic.23.2014.05.14.05.54.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 May 2014 05:54:46 -0700 (PDT) From: Thomas Monjalon To: "Richardson, Bruce" Date: Wed, 14 May 2014 14:54:44 +0200 Message-ID: <1983230.AZ6L98DUtD@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.2-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <59AF69C657FD0841A61C55336867B5B01AA19761@IRSMSX103.ger.corp.intel.com> References: <1400062955-27338-1-git-send-email-bruce.richardson@intel.com> <1725713.WtaYEVcYoT@xps13> <59AF69C657FD0841A61C55336867B5B01AA19761@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: allow updates to build config on make install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 May 2014 12:54:39 -0000 2014-05-14 12:33, Richardson, Bruce: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > You would like to have a synchronization of your generated .config file > > with the configuration template. But it's not possible for the simple > > reason that you may have modified your .config file so there is no simple > > correlation with the original template. > > Would you agree then that the ideal state matrix for a make install should > probably be: * template unmodified, config unmodified - No issue - > regenerate or not as best suits the code * template unmodified, config > modified - don't regenerate, keep local config * template modified, config > modified - flag an error, since continuing compile with old config on new > code will lead to undefined build results, since config template changes > rarely occur without code changes to go with them. * template modified, > config unmodified - regenerate new config, overwriting old one, for the > same reason above. [Optionally print out message stating that the config is > being regenerated] > > Does this seem reasonable to you? The last case is the common case for me in > development, as I've had multiple build errors and unexpected build results > in the last week alone due to config template changes not propagating as I > switch development branches to work on different features. It seems reasonable. So you plan to send a v2 with this algorithm? -- Thomas