From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3830A0C46; Fri, 23 Jul 2021 10:11:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3421540040; Fri, 23 Jul 2021 10:11:16 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 7A0544003C; Fri, 23 Jul 2021 10:11:15 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 0C93E5C00E5; Fri, 23 Jul 2021 04:11:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 23 Jul 2021 04:11:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= QEJ/ugDMaMTJZScEb85pOzNkEAvsrRrtFYYm9TewjZY=; b=B/EcefwGhl6LjKm/ ITljlXGS4BnUWhEQeUdMor02Om1nQMsbEYkDV+p6QhDpMldNXodgyH1NvM7KO+69 8iaZtbManl2+3cNFGZuhztqWUCBrdJacYEl7fwjP1LNVRrayMkP293ZlpX605Rb1 qA5hp6Y36Hplq1Dr8DK38gZVuk9YnRGxnjK9X0RFD+LPWbrPTLqvXHT8CPs8qxrY ot+krA38OwNdOhsA8CMbRU/qplZkLAJhq7R55LTBAIW9xOXACAGZJDF1e9fDtzn4 xGObSrK3oGYofvf5OenTJOSmZ/bvYQ6YA/+q7ly9wrphUDZRFCPuSPPCew/Puu8I tDfvNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=QEJ/ugDMaMTJZScEb85pOzNkEAvsrRrtFYYm9Tewj ZY=; b=CV75lYbrnC8JYlr0pl7l+glNe1/4u5/5yGcBDl8ky1tRUSQ+R5NRba+eE T/hcLvPV/6MOS9e4WYOi0g8N7gTCFJJOInLKZv1+IKieyeu6Ls+RDQjzv6PZEM7B 19aDFnZXs9FMvySWxdJjj3nyUZ89p9Tpxuiu3lLuP7/HlL5g+pNNJXvYnrtEALQa /2H/Ex/h6uzRS0QqFHmMe5kpfnlIWzuXGYqYWNhW1k+rPZtJsiUH5ElLLg3n/uMi VyhHfazKu0IRd8+jnO2dyiIL5NXYgho71C9Q5pG9KQk1MY9f3Dq4+1hXyBq8ceDs fkMByIpUaMwus09kgIWfiLGMUc7sw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeekgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Jul 2021 04:11:14 -0400 (EDT) From: Thomas Monjalon To: "Yu, DapengX" Cc: "Dumitrescu, Cristian" , dev@dpdk.org, "stable@dpdk.org" , "Singh, Jasvinder" Date: Fri, 23 Jul 2021 10:11:35 +0200 Message-ID: <1983758.jzM3WOmxh8@thomas> In-Reply-To: References: <20210714054702.764366-1-dapengx.yu@intel.com> <20210715053814.978200-1-dapengx.yu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] net/softnic: fix memory leak in parsing arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > From: Dapeng Yu > > > > In function pmd_parse_args(), firmware path is duplicated from device > > arguments as character string, but is never freed, which cause memory leak. > > > > This patch changes the type of firmware member of struct pmd_params to > > character array, to make memory resource release unnecessary, and > > changes the type of name member to character array, to keep the > > consistency of character string handling in struct pmd_params. > > > > Fixes: 7e68bc20f8c8 ("net/softnic: restructure") > > Cc: stable@dpdk.org > > > > Signed-off-by: Dapeng Yu > > Acked-by: Jasvinder Singh Applied, thanks.