From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E3FF25942 for ; Mon, 1 May 2017 22:22:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6F86E209A5; Mon, 1 May 2017 16:22:27 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 01 May 2017 16:22:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=mSaufQxccmWXQBi iuunVSuf7KY/MTvH84USfbvUKSuU=; b=gztjVhdyiK8rY42DCGGjlSFsyHlS584 wH6lnBxSvt8RiC/WJvAm1N9Uz16HWL3f2cuiSanP9h/vU/lboDjMHjHLVdaSWjI/ vytieqMsut/5z8qvuruAfbJgMKZEms7J+EpGk3XYcGkLvtsKXvUp8Pcn/jstEEin MJKMUWQYeEPI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=mSaufQxccmWXQBiiuunVSuf7KY/MTvH84USfbvUKSuU=; b=MFtMqCHb TRts76GhHdLswBmRX117/KmycbJ19G56LQFlf0IcybOAe2+D1unL2tSoKL/gIaBM iWu8G0sKWHgIgOxRw3B3UyJwPOTXtI8NDHtSlIUdwFZ7zqZcy59gma7JJIXEajAI SFOdb26ehH/RmSSjeoBWlsN0T8uWi6B9ESqKAKOY6OXjacOK/Z3pg+g+gjiQUUWV NjWHhM16CNfGtiXmqQqU/kcMnv62Z4i8WOXgtERWYaLJyw29zQtSqYOaKs+Ni56y CwO+aR1Uc1WgVZFmaxNsFpKrHDR9vbBgtvoZVQPvsnXGlGqfr17WkMLLN7X0nByz gLJwJCMc/itb/Q== X-ME-Sender: X-Sasl-enc: riG0IQslOSE90ckgN3PM1TyVuLSEVqRLVOnSlLEQg7GG 1493670147 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2AA2F247AB; Mon, 1 May 2017 16:22:27 -0400 (EDT) From: Thomas Monjalon To: "Patil, Harish" , Remy Horton Cc: dev@dpdk.org, Pablo de Lara , "jingjing.wu@intel.com" Date: Mon, 01 May 2017 22:22:26 +0200 Message-ID: <1984316.gczFh5jcb3@xps> In-Reply-To: References: <1493211774-28249-1-git-send-email-remy.horton@intel.com> <1493377213-156955-1-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add bitrate stats option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 May 2017 20:22:28 -0000 01/05/2017 22:07, Patil, Harish: > Hi Remy, > Have a small suggestion here. > Since testpmd uses new libraries of librte_latencystats and > librte_bitratestats it hurts packet processing performance. > Many users who use testpmd to do the initial performance benchmarks may > not be aware of such a feature is default enabled. Yes, the default config of testpmd must give good performance. > So can we disable this feature by default in the config? > =B7 CONFIG_RTE_LIBRTE_BITRATE=3Dn > =B7 CONFIG_RTE_LIBRTE_LATENCY_STATS=3Dn > Only those folks interested in latency/jitter measurements can recompile > with those configs enabled. I disagree about compile-time options. It should be a run-time option of testpmd. Please Remy (or others), disable the metrics in the default configuration of testpmd, before the 17.05 release. You have few days, it is urgent.