From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B79E72C08 for ; Tue, 27 Jun 2017 11:59:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 341E5219E6; Tue, 27 Jun 2017 05:59:12 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 27 Jun 2017 05:59:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=UwMqIo6L+gtZnhI nQGA77E1mgp+0Y5JGrqeziNYyXlg=; b=XO84KjUMcurjpPUD7R3zNmcbbKFHlIo +5fFX8Nh/JxmzWvH2sA2ZlqPh00W7y81EgAgpiShJsX+ErU5PZyHBK2quqISXOKL yKKq7coid60CVTR7aoSvWiFRs+sKgRhMbM9HKTraO/4oFkpgGnXeNmss13g8MoDQ Al3wjJjv5JbA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=UwMqIo6L+gtZnhInQGA77E1mgp+0Y5JGrqeziNYyXlg=; b=F015EM/U 8I7JxrtjWbOCbN9oChJAQGGyyb79pZgMqEj8KsIXtmxZsWaOKClRw0yt+2XB3KZp ZpWxBOVQxdfFz5WdNDRkqLcm2LQmiscbRVt7y0jwqM5ZdUc9A5og1kTb2f7bGn9h nu5eIQPFcQmZQ2vHldPkb5vHb3Rb40n1nk6h5McgdhjKjfXMIceEYPiL1V1Uf3VI 3NjUEhkfjgn6DLpsslT4mvlZ9i6E+mnYeKuhcmBjOfiWfW+7YtBrxFC4vVBMbaMo NvGa2srzAcPfarbGpb9Hkuzi9Oe42P+QY//adq1ifM60BkvdiEeTfxmaDHp2Br8t gaTElzwrfvNREA== X-ME-Sender: X-Sasl-enc: zvxgh1usHWS0HzpbyHze8OdyOkVVCXktc+2CMQL2rXL+ 1498557551 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D32EC7E74F; Tue, 27 Jun 2017 05:59:11 -0400 (EDT) From: Thomas Monjalon To: Hemant Agrawal , Jerin Jacob , Jianbo Liu Cc: Ilya Maximets , dev@dpdk.org, David Marchand , Sergio Gonzalez Monroy , Heetae Ahn , Yuanhan Liu , Jianfeng Tan , Neil Horman , Yulong Pei , Bruce Richardson Date: Tue, 27 Jun 2017 11:59:11 +0200 Message-ID: <1986282.JS30ShZ19C@xps> In-Reply-To: <5bae3303-1457-5391-2334-9108b7d42055@nxp.com> References: <1498039711-26570-1-git-send-email-i.maximets@samsung.com> <2224754.8CF9r2HNLB@xps> <5bae3303-1457-5391-2334-9108b7d42055@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 2/2] config: enable vhost numa awareness by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 09:59:13 -0000 27/06/2017 11:41, Hemant Agrawal: > On 6/27/2017 2:51 PM, Thomas Monjalon wrote: > > 27/06/2017 11:18, Hemant Agrawal: > >> On 6/27/2017 2:16 PM, Ilya Maximets wrote: > >>> It is safe to enable LIBRTE_VHOST_NUMA by default for all > >>> configurations where libnuma is already a default dependency. > >>> > >>> Signed-off-by: Ilya Maximets > >>> --- > >>> config/common_linuxapp | 1 + > >>> config/defconfig_arm-armv7a-linuxapp-gcc | 1 + > >>> config/defconfig_arm64-dpaa2-linuxapp-gcc | 1 + > >>> 3 files changed, 3 insertions(+) > > [...] > >>> --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc > >>> +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc > >>> @@ -47,6 +47,7 @@ CONFIG_RTE_PKTMBUF_HEADROOM=256 > >>> > >>> # Doesn't support NUMA > >>> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y > >>> +CONFIG_RTE_LIBRTE_VHOST_NUMA=n > >>> > >>> # > >>> # Compile Support Libraries for DPAA2 > >>> > >> > >> -1 > >> It should also be disabled for generic ARM64. This patch is breaking > >> generic arm64 config tests on our platforms and creating a unnecessary > >> dependency. > > > > What do you mean? Which ARM64 platform is it breaking? > > We can specifically disable it on more platforms. > > > Unlike x86, ARM only represent a core architecture. > Different platforms can integrate these cores differently in their SoCs. > The stock ARM v8 cores do not provide support for NUMA in my knowledge. > Some vendors have modified ARM cores (e.g. Cavium) to support NUMA > architecture. However that is not a common phenomena. > NUMA config should not be default for generic ARM config. It should be > enabled only for architecture supporting it. > > So, *arm64-armv8a-linuxapp-gcc* config is being used by several vendors > include NXP. e.g. We use this config on several of our low end systems > (non-dpaa). Also, we use it when running in VM with virtio interfaces on > all of our different platforms (non-dpaa, dpaa1, dpaa2 etc). We need more opinions from ARM and Cavium. The general idea in DPDK config is to enable as much feature as we can. It conflicts with the general availability of NUMA on ARMv8.