From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36CF1A034F; Mon, 25 Nov 2019 23:40:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E7DACF3; Mon, 25 Nov 2019 23:40:48 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id A114A91; Mon, 25 Nov 2019 23:40:46 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2E05C22725; Mon, 25 Nov 2019 17:40:46 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 25 Nov 2019 17:40:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=+cCb7caqH5lN5xUSkpg1QxU6mgGBfF/oZs4zBmyP/ZI=; b=Kc6TFuJdLgZe gdmsLvIMu6tM/zWG6vHGcCqO/sOw6YOzPXx6D6vWANHy+HN10IV4rP58UEr1gqk+ 8hiaWtma+HENVZo6tPlBPVTqvjcDtUomsVT2NIN/3tUnqtZBSWI7deoxJA5IFO1r VraZdz1wBiPS6A2OPCzKNsU+Q0ShF6w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=+cCb7caqH5lN5xUSkpg1QxU6mgGBfF/oZs4zBmyP/ ZI=; b=iA7VJ2hjy7oWjsv7lHWfvlBs9y7CryZY5M9VAkNgRf5MdJePI6CX/6/vb 6Mhj6ECffVuAiaZEnxrfsPt4Sx7WhXRwbXyiW/13XLo305E4eiuCMywWVjFFEjn3 HpbgYWS+mPTI81vD8jsDh84IubKbF0eSyhHzL7W2i2DsxKA3ChCtkNH00j1e3j5h Z09s1mFLgqLx0eEHfd/Rc6ixN3eYrp69PGBNqJfB8cBzF1fkQgZdEN92GUzLvW53 Tw6HHg9EakPKTacS5oqvNtSlsV9WS8wesL26n02EpGzCcoo6O4La0qgXLRhMx5fV RqZO0rw1pLqmteuVUEPigDvwgqjrQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeivdcutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffohhmrg hinhephhhurghrmhdrtghomhenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuve hluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A0E388005B; Mon, 25 Nov 2019 17:40:44 -0500 (EST) From: Thomas Monjalon To: Gavin Hu Cc: stable@dpdk.org, dev@dpdk.org, nd@arm.com, Honnappa.Nagarahalli@arm.com, dharmik.thakkar@arm.com Date: Mon, 25 Nov 2019 23:40:43 +0100 Message-ID: <1986568.lXXHI0cLKO@xps> In-Reply-To: <1574652993-17755-1-git-send-email-gavin.hu@arm.com> References: <1573450911-24317-2-git-send-email-gavin.hu@arm.com> <1574652993-17755-1-git-send-email-gavin.hu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] test/rcu: fix build for small number of cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/11/2019 04:36, Gavin Hu: > If the RTE_MAX_LCORE is less than 10, a compilation error is generated: > app/test/test_rcu_qsbr.c:234:10: error: comparison of integer > expressions of different signedness: =E2=80=98unsigned int=E2=80=99 and = =E2=80=98int=E2=80=99 > [-Werror=3Dsign-compare] >=20 > The cause is (RTE_MAX_LCORE - 10) results in a negative value. >=20 > To fix, use rte_rand() to find a number between 0 and RTE_MAX_LCORE. >=20 > Fixes: b87089b0bb19 ("test/rcu: add API and functional tests") > Cc: stable@dpdk.org >=20 > Signed-off-by: Gavin Hu > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Steve Capper > Reviewed-by: Dharmik Thakkar Applied, thanks