From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BC79A04B1; Mon, 23 Nov 2020 15:20:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5014C8C4; Mon, 23 Nov 2020 15:20:31 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 87CEA375B for ; Mon, 23 Nov 2020 15:20:29 +0100 (CET) IronPort-SDR: DXx45dGExNRDSAvrsvMqCYvC1rd3S4urjKsus2u3hswqlGncCxr//GbfUkrzZ4RUcK/wuEi5Kv xvd6Up0O80Pg== X-IronPort-AV: E=McAfee;i="6000,8403,9813"; a="151614522" X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="151614522" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 06:20:27 -0800 IronPort-SDR: YodheI4WOBdl6H5jKOERe510mOBIYnEEdiQfeuC15HnDYwApwd+o+0nr1rqdGPzmvDpezybudJ 8oaZaOtRL1rQ== X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="327214078" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.20.15]) ([10.252.20.15]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 06:20:23 -0800 To: Jiawei Wang , wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, orika@nvidia.com, viacheslavo@nvidia.com, thomas@monjalon.net, rasland@nvidia.com, Andrew Rybchenko Cc: dev@dpdk.org References: <1606120170-232448-1-git-send-email-jiaweiw@nvidia.com> <1606129239-379967-1-git-send-email-jiaweiw@nvidia.com> From: Ferruh Yigit Message-ID: <1986e099-79ce-83f8-2300-5ff74384690f@intel.com> Date: Mon, 23 Nov 2020 14:20:22 +0000 MIME-Version: 1.0 In-Reply-To: <1606129239-379967-1-git-send-email-jiaweiw@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5] app/testpmd: fix testpmd packets dump overlapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/23/2020 11:00 AM, Jiawei Wang wrote: > When testpmd enabled the verbosity for the received packets, if two packets > were received at the same time, for example, sampling packet and normal > packet, the dump output of these packets may be overlapping due to multiple > core handling the multiple queues simultaneously. > > The patch uses one string buffer that collects all the packet dump output > into this buffer and then printouts it at last, that guarantees to printout > separately the dump output per packet. > > Fixes: d862c45 ("app/testpmd: move dumping packets to a separate function") > > Signed-off-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko Reviewed-by: Ferruh Yigit Although this looks safe, this is also not so critical, not sure to get for this release or not.