From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 585F6C38E
 for <dev@dpdk.org>; Mon, 13 Apr 2015 12:47:05 +0200 (CEST)
Received: by wgsk9 with SMTP id k9so76141662wgs.3
 for <dev@dpdk.org>; Mon, 13 Apr 2015 03:47:05 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=ptb7unsVPrYz18i92HMQM5fxj9Q+5uvR02vDpvWpCn4=;
 b=FTW8wCovIdUlkuZQkmpolxYp9A3LScLyHy3qMXz5Mk+bcdfOZvwETnU3W29G3SA8tX
 dXVRryfrgBJlaF1CAz3G708XE2zdrKAmgULj8uX9ypN/WR3Zxm8qfD02evfVnGH4gBvH
 TYEqS6fkN1TOW1OnALXT2wp/lPvhl/BEYgtxHhY3xhSfmSHu5eI9oHTVEZr1wC5a5j95
 3jnLUY52ion4U8fgRXhkJg3i38LHYd2E8skF3MbGXgRl7+w0kHjM68acK5fHZht9AVYi
 1jXQM13TnJmFS+0klZyTxQQEBnrI7jXHQuKtWDehMlm2n47zLfC9w2xoM2j0nce8wcsB
 9ntQ==
X-Gm-Message-State: ALoCoQkb/3cs+hsVRF1Sj+wO1xnzfW8rlasWCQlwIUe+hhPByHHySp4Zk+0NejDQ7uBURX9wUW6R
X-Received: by 10.180.21.178 with SMTP id w18mr20202373wie.90.1428922025219;
 Mon, 13 Apr 2015 03:47:05 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id ey10sm12233401wib.2.2015.04.13.03.47.04
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 13 Apr 2015 03:47:04 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Raz Amir <razamir22@gmail.com>
Date: Mon, 13 Apr 2015 12:46:23 +0200
Message-ID: <19871442.I62j3xGbVC@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <145601d07214$20aa04b0$61fe0e10$@gmail.com>
References: <13b901d07149$4e20d430$ea627c90$@gmail.com>
 <145601d07214$20aa04b0$61fe0e10$@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Crash related to virtio NICs in DPDK 2.0.0 on
	Freebsd 10.1 VM
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Apr 2015 10:47:05 -0000

2015-04-08 18:53, Raz Amir:
> The issues happens also in dpdk 1.8.0, and related to patch
> http://dpdk.org/dev/patchwork/patch/239/
> 
> Adding Thomas and David to the thread and I will appreciate your input.
> 
> The patch comes to solve a file descriptor leak in the bsdapp version of
> rte_eal_iopl_init after opening the /dev/io device.
> 
> Seems like this isn't a file descriptor leak, and it should remain open - as
> I wrote below, I am using virtio.

Thanks for the bug report.
It seems there was no validation for FreeBSD with virtio.

> After removing it and testing the crash was resolved.
> 
> Any objection for removing the close(fd) that was added at dpdk 1.8.0?

No, there was a doubt because the man page was not clear.
	http://www.freebsd.org/cgi/man.cgi?query=io&sektion=4

In case you submit a patch, please add this line:
Fixes: 8a312224bcde ("eal/bsd: fix fd leak")

> Are there scenarios that might be impacted by removing it?

I don't think so.

Thanks