From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id A1B76374C for ; Tue, 15 Dec 2015 15:21:38 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id n186so28115565wmn.0 for ; Tue, 15 Dec 2015 06:21:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Eve20w+oeZ4AeBdx9ZInteozE1PfxNDBRsg+uL3j8i4=; b=SbWu2ip3OeaY2bUFw8l8PeIpwENXpjlm7TKMATnkIt9IW5Rv42BHQgmdoxwxg3kGGW HNTZQEo7hHaofvBQFFf4XnNkl4TPQgvJVg30fnuGZoTw8Vhn0OIBh3bevq6gydDNXaKQ Xq66JzjQk9aeDO2jeiSw1tdshnzZWgBSzX7qWiKYqb0P8/rbtXga2g4dHnEibk+0hzH0 RAtFSsz2hpTIRPuPLTEpDrOSqR0F5KkwMkqvYOTjUqatzs/wxeMh+a7qaLgIzw+6oDZU Q35w4felE6I+hT5Cf66t+Mqskp9cfARHuALy95nlkAzLXJbJqg86nz7iyN3npQFpj9gc HEcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Eve20w+oeZ4AeBdx9ZInteozE1PfxNDBRsg+uL3j8i4=; b=cAzv4EtX1lfTBFyYV3bbRpQVwotzbkNdHQkjCitwk+soHpCqFsRBmAp9QakpmC1KCR a46tKVN9lbseIlmuKb2xt8eEuICEN/eGgUKmjiudwrYJaFBg9kVfYOHzke2hI0/3f8Ex 4OKJTLwF+d573oANewGPi3OYn55ZldLgn2JiYJiFYgMXkXob03fCMEqW6t+6F18YFIzm 3Iyeexrpfxn4JavuifFTkMgoxo0Eyn20nD46iDHHSc0yQOWxpuDYjVlBm8uiZOsOtJ+T v6VzXJHSd8CQgLswywtcjzmVPfLjlVw5Iu3ytvufhj5uPCVmgG4JeRd9DF3fPAfTO4Ts rL4w== X-Gm-Message-State: ALoCoQkLzWvOD4mmQf2zJlmrD+OtjbChRhNbRdc+TljC9B7Jm8gJLWMHkGgEjJb3c0PLxCBJbt3S3qHBQrQevcibITeusQgILQ== X-Received: by 10.28.220.197 with SMTP id t188mr4978691wmg.20.1450189298489; Tue, 15 Dec 2015 06:21:38 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id 198sm3048973wmr.18.2015.12.15.06.21.37 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 15 Dec 2015 06:21:37 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Tue, 15 Dec 2015 15:20:22 +0100 Message-ID: <19875956.4ZuBgesspA@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151215141640.GA25595@hmsreliant.think-freely.org> References: <20151215141640.GA25595@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] scripts: fix abi-validator regression when revision is a tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 14:21:38 -0000 2015-12-15 09:16, Neil Horman: > On Tue, Dec 15, 2015 at 03:55:15PM +0200, Panu Matilainen wrote: > > Commit 9cbae2aa64eb managed to break the only previously supported > > case where a tag is used as a revision, due to git show output > > differing between tags and other objects. The hash is on the last > > line of the output in both cases though so just grab that. > > > > Fixes: 9cbae2aa64eb ("scripts: support any git revisions as ABI validation range") > > Signed-off-by: Panu Matilainen > > --- > > scripts/validate-abi.sh | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh > > index 8d7be24..c36ad61 100755 > > --- a/scripts/validate-abi.sh > > +++ b/scripts/validate-abi.sh > > @@ -121,8 +121,8 @@ then > > cleanup_and_exit 1 > > fi > > > > -HASH1=$(git show -s --format=%H "$TAG1" -- 2> /dev/null) > > -HASH2=$(git show -s --format=%H "$TAG2" -- 2> /dev/null) > > +HASH1=$(git show -s --format=%H "$TAG1" -- 2> /dev/null | tail -1) > > +HASH2=$(git show -s --format=%H "$TAG2" -- 2> /dev/null | tail -1) > > > > # Make sure our tags exist > > res=$(validate_tags) > Acked-by: Neil Horman Applied, thanks