From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9712D2BA2 for ; Fri, 19 Apr 2019 11:30:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DFE4E20CB1; Fri, 19 Apr 2019 05:30:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 05:30:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vDk124ZS7AYjrU8IGWzrLqnTURxQBx9RZKI/7vLvbXU=; b=Fk5z/a4O/Z5S MwZBr9YNdrOZ+Af34znBKGsro+/jQDJTMdkR88lS3RkwBMg3IFkO4l6Ua39gmtfr KSJWy5PXqhz6fa30l41DtTWn6tZUFXhYcekH75Gy4l9AzNsERVJENNcXtbYTXex0 t6utuDJVl3JApKwqx5dSZ7Io0sg2Qtw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=vDk124ZS7AYjrU8IGWzrLqnTURxQBx9RZKI/7vLvb XU=; b=sD3643qtgbT4DMgFCCgVbc8wkZ8uovZ3ZPL3TbADkuwWb327zKw2tCo9P MJZjTSuZSlYJ23u1AcSoCDhbUA2RMHN8QlfvyXSwQJn3vCGAbkHop2bbTmerw5D6 GhChcAUIi6UObc7PtXenogwzksmRDI1/Y0/4rdo+HN8LyiM7pRnTehN5GwSNENHC qyshdZg42jQFI02wA6t2RciGFrcI0eqsq/ajXsFXU55kueyTYWZGSayXdXYROOYi fUU7X+lfYiokHSFex92x25Fo0+rIzToNjRLSXYdR7lcbNA60I9J7TLX0h8j8UjYl rP4Jh/NcOjkmgMt+HG7HXshnlr2+Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeejgdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F3E4C103CC; Fri, 19 Apr 2019 05:30:22 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: "Cel, TomaszX" , "Jozwiak, TomaszX" , Yongseok Koh , "dev@dpdk.org" , "Trahe, Fiona" , "Yigit, Ferruh" Date: Fri, 19 Apr 2019 11:30:17 +0200 Message-ID: <1988563.CbslbgrKNx@xps> In-Reply-To: References: <1550223873-17119-3-git-send-email-tomaszx.jozwiak@intel.com> <2973149.5co8HxeFWj@xps> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 09:30:26 -0000 19/04/2019 11:25, David Marchand: > On Fri, Apr 19, 2019 at 11:08 AM Thomas Monjalon > wrote: >=20 > > There are some variables declared in the middle of the function, > > and one (i) is declared twice with two different types. > > > > Tomasz and Tomasz, are you working on it urgently please? > > >=20 > Found out that this test is not built by default. > I have a trivial fix but I wonder how this has been tested seeing how it > won't compile. It is enabled with devtools/test-build.sh and it is compiling fine with recent compilers I think. Please send your fix. > > 19/04/2019 00:42, Yongseok Koh: > > > Hi, > > > > > > I'm seeing compile error. > > > Isn't it due to this patch? > > > > > > $ gcc --version > > > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) > > > > > > > > > FAILED: app/test/app@test@@dpdk-test@exe/test_compressdev.c.o > > [...] > > > ../app/test/test_compressdev.c: In function > > =E2=80=98test_compressdev_deflate_stateless_dynamic_big=E2=80=99: > > > ../app/test/test_compressdev.c:1992:16: error: conflicting types for = =E2=80=98i=E2=80=99 > > > for (uint32_t i =3D 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > > > ^ > > > ../app/test/test_compressdev.c:1949:11: note: previous definition of = =E2=80=98i=E2=80=99 > > was here > > > uint16_t i =3D 0; > > > ^ > > > ../app/test/test_compressdev.c:1992:2: error: =E2=80=98for=E2=80=99 l= oop initial > > declarations are only allowed in C99 mode > > > for (uint32_t i =3D 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > > > ^ > > > ../app/test/test_compressdev.c:1992:2: note: use option -std=3Dc99 or > > -std=3Dgnu99 to compile your code > > > ../app/test/test_compressdev.c:1996:19: warning: assignment from > > incompatible pointer type [enabled by default] > > > int_data.buf_idx =3D &i; > > > ^ > > > [1501/1523] Generating igb_uio with a custom command. > > > make: Entering directory `/usr/src/kernels/3.10.0-862.el7.x86_64' > > > CC [M] > > /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_u= io/igb_uio.o > > > Building modules, stage 2. > > > MODPOST 1 modules > > > make[1]: Warning: File > > `/auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_= uio/igb_uio.mod.c' > > has modification time 0.0096 s in the future > > > CC > > /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_u= io/igb_uio.mod.o > > > LD [M] > > /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_u= io/igb_uio.ko > > > make[1]: warning: Clock skew detected. Your build may be incomplete. > > > make: Leaving directory `/usr/src/kernels/3.10.0-862.el7.x86_64' > > > > > > > > > Thanks, > > > Yongseok > > > > [...] > > > >> +static int > > > >> +test_compressdev_deflate_stateless_dynamic_big(void) > > > >> +{ > > > >> + struct comp_testsuite_params *ts_params =3D &testsuite_params; > > > >> + uint16_t i =3D 0; > > > >> + int ret =3D TEST_SUCCESS; > > > >> + const struct rte_compressdev_capabilities *capab; > > > >> + char *test_buffer =3D NULL; > > > >> + > > > >> + capab =3D rte_compressdev_capability_get(0, > > > >> RTE_COMP_ALGO_DEFLATE); > > > >> + TEST_ASSERT(capab !=3D NULL, "Failed to retrieve device > > capabilities"); > > > >> + > > > >> + if ((capab->comp_feature_flags & > > > >> RTE_COMP_FF_HUFFMAN_DYNAMIC) =3D=3D 0) > > > >> + return -ENOTSUP; > > > >> + > > > >> + if ((capab->comp_feature_flags & > > > >> RTE_COMP_FF_OOP_SGL_IN_SGL_OUT) =3D=3D 0) > > > >> + return -ENOTSUP; > > > >> + > > > >> + test_buffer =3D rte_malloc(NULL, BIG_DATA_TEST_SIZE, 0); > > > >> + if (test_buffer =3D=3D NULL) { > > > >> + RTE_LOG(ERR, USER1, > > > >> + "Can't allocate buffer for big-data\n"); > > > >> + return TEST_FAILED; > > > >> + } > > > >> + > > > >> + struct interim_data_params int_data =3D { > > > >> + (const char * const *)&test_buffer, > > > >> + 1, > > > >> + NULL, > > > >> + &ts_params->def_comp_xform, > > > >> + &ts_params->def_decomp_xform, > > > >> + 1 > > > >> + }; > > > >> + > > > >> + struct test_data_params test_data =3D { > > > >> + RTE_COMP_OP_STATELESS, > > > >> + SGL_BOTH, > > > >> + ZLIB_DECOMPRESS, > > > >> + 0, > > > >> + 1 > > > >> + }; > > > >> + > > > >> + ts_params->def_comp_xform->compress.deflate.huffman =3D > > > >> + > > > >> RTE_COMP_HUFFMAN_DYNAMIC; > > > >> + > > > >> + /* fill the buffer with data based on rand. data */ > > > >> + srand(BIG_DATA_TEST_SIZE); > > > >> + for (uint32_t i =3D 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > > > >> + test_buffer[i] =3D (uint8_t)(rand() % ((uint8_t)-1)) | = 1; > > > >> + > > > >> + test_buffer[BIG_DATA_TEST_SIZE-1] =3D 0; > > > >> + int_data.buf_idx =3D &i; > > > > > > > > >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C1E86A00E6 for ; Fri, 19 Apr 2019 11:30:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69F811BA96; Fri, 19 Apr 2019 11:30:26 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9712D2BA2 for ; Fri, 19 Apr 2019 11:30:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DFE4E20CB1; Fri, 19 Apr 2019 05:30:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 05:30:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vDk124ZS7AYjrU8IGWzrLqnTURxQBx9RZKI/7vLvbXU=; b=Fk5z/a4O/Z5S MwZBr9YNdrOZ+Af34znBKGsro+/jQDJTMdkR88lS3RkwBMg3IFkO4l6Ua39gmtfr KSJWy5PXqhz6fa30l41DtTWn6tZUFXhYcekH75Gy4l9AzNsERVJENNcXtbYTXex0 t6utuDJVl3JApKwqx5dSZ7Io0sg2Qtw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=vDk124ZS7AYjrU8IGWzrLqnTURxQBx9RZKI/7vLvb XU=; b=sD3643qtgbT4DMgFCCgVbc8wkZ8uovZ3ZPL3TbADkuwWb327zKw2tCo9P MJZjTSuZSlYJ23u1AcSoCDhbUA2RMHN8QlfvyXSwQJn3vCGAbkHop2bbTmerw5D6 GhChcAUIi6UObc7PtXenogwzksmRDI1/Y0/4rdo+HN8LyiM7pRnTehN5GwSNENHC qyshdZg42jQFI02wA6t2RciGFrcI0eqsq/ajXsFXU55kueyTYWZGSayXdXYROOYi fUU7X+lfYiokHSFex92x25Fo0+rIzToNjRLSXYdR7lcbNA60I9J7TLX0h8j8UjYl rP4Jh/NcOjkmgMt+HG7HXshnlr2+Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeejgdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F3E4C103CC; Fri, 19 Apr 2019 05:30:22 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: "Cel, TomaszX" , "Jozwiak, TomaszX" , Yongseok Koh , "dev@dpdk.org" , "Trahe, Fiona" , "Yigit, Ferruh" Date: Fri, 19 Apr 2019 11:30:17 +0200 Message-ID: <1988563.CbslbgrKNx@xps> In-Reply-To: References: <1550223873-17119-3-git-send-email-tomaszx.jozwiak@intel.com> <2973149.5co8HxeFWj@xps> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419093017.Rrpz54sRAQizeAUlP0DCBk0Zzz_bzgGA2Tyh4M-5VBE@z> 19/04/2019 11:25, David Marchand: > On Fri, Apr 19, 2019 at 11:08 AM Thomas Monjalon > wrote: >=20 > > There are some variables declared in the middle of the function, > > and one (i) is declared twice with two different types. > > > > Tomasz and Tomasz, are you working on it urgently please? > > >=20 > Found out that this test is not built by default. > I have a trivial fix but I wonder how this has been tested seeing how it > won't compile. It is enabled with devtools/test-build.sh and it is compiling fine with recent compilers I think. Please send your fix. > > 19/04/2019 00:42, Yongseok Koh: > > > Hi, > > > > > > I'm seeing compile error. > > > Isn't it due to this patch? > > > > > > $ gcc --version > > > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) > > > > > > > > > FAILED: app/test/app@test@@dpdk-test@exe/test_compressdev.c.o > > [...] > > > ../app/test/test_compressdev.c: In function > > =E2=80=98test_compressdev_deflate_stateless_dynamic_big=E2=80=99: > > > ../app/test/test_compressdev.c:1992:16: error: conflicting types for = =E2=80=98i=E2=80=99 > > > for (uint32_t i =3D 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > > > ^ > > > ../app/test/test_compressdev.c:1949:11: note: previous definition of = =E2=80=98i=E2=80=99 > > was here > > > uint16_t i =3D 0; > > > ^ > > > ../app/test/test_compressdev.c:1992:2: error: =E2=80=98for=E2=80=99 l= oop initial > > declarations are only allowed in C99 mode > > > for (uint32_t i =3D 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > > > ^ > > > ../app/test/test_compressdev.c:1992:2: note: use option -std=3Dc99 or > > -std=3Dgnu99 to compile your code > > > ../app/test/test_compressdev.c:1996:19: warning: assignment from > > incompatible pointer type [enabled by default] > > > int_data.buf_idx =3D &i; > > > ^ > > > [1501/1523] Generating igb_uio with a custom command. > > > make: Entering directory `/usr/src/kernels/3.10.0-862.el7.x86_64' > > > CC [M] > > /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_u= io/igb_uio.o > > > Building modules, stage 2. > > > MODPOST 1 modules > > > make[1]: Warning: File > > `/auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_= uio/igb_uio.mod.c' > > has modification time 0.0096 s in the future > > > CC > > /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_u= io/igb_uio.mod.o > > > LD [M] > > /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_u= io/igb_uio.ko > > > make[1]: warning: Clock skew detected. Your build may be incomplete. > > > make: Leaving directory `/usr/src/kernels/3.10.0-862.el7.x86_64' > > > > > > > > > Thanks, > > > Yongseok > > > > [...] > > > >> +static int > > > >> +test_compressdev_deflate_stateless_dynamic_big(void) > > > >> +{ > > > >> + struct comp_testsuite_params *ts_params =3D &testsuite_params; > > > >> + uint16_t i =3D 0; > > > >> + int ret =3D TEST_SUCCESS; > > > >> + const struct rte_compressdev_capabilities *capab; > > > >> + char *test_buffer =3D NULL; > > > >> + > > > >> + capab =3D rte_compressdev_capability_get(0, > > > >> RTE_COMP_ALGO_DEFLATE); > > > >> + TEST_ASSERT(capab !=3D NULL, "Failed to retrieve device > > capabilities"); > > > >> + > > > >> + if ((capab->comp_feature_flags & > > > >> RTE_COMP_FF_HUFFMAN_DYNAMIC) =3D=3D 0) > > > >> + return -ENOTSUP; > > > >> + > > > >> + if ((capab->comp_feature_flags & > > > >> RTE_COMP_FF_OOP_SGL_IN_SGL_OUT) =3D=3D 0) > > > >> + return -ENOTSUP; > > > >> + > > > >> + test_buffer =3D rte_malloc(NULL, BIG_DATA_TEST_SIZE, 0); > > > >> + if (test_buffer =3D=3D NULL) { > > > >> + RTE_LOG(ERR, USER1, > > > >> + "Can't allocate buffer for big-data\n"); > > > >> + return TEST_FAILED; > > > >> + } > > > >> + > > > >> + struct interim_data_params int_data =3D { > > > >> + (const char * const *)&test_buffer, > > > >> + 1, > > > >> + NULL, > > > >> + &ts_params->def_comp_xform, > > > >> + &ts_params->def_decomp_xform, > > > >> + 1 > > > >> + }; > > > >> + > > > >> + struct test_data_params test_data =3D { > > > >> + RTE_COMP_OP_STATELESS, > > > >> + SGL_BOTH, > > > >> + ZLIB_DECOMPRESS, > > > >> + 0, > > > >> + 1 > > > >> + }; > > > >> + > > > >> + ts_params->def_comp_xform->compress.deflate.huffman =3D > > > >> + > > > >> RTE_COMP_HUFFMAN_DYNAMIC; > > > >> + > > > >> + /* fill the buffer with data based on rand. data */ > > > >> + srand(BIG_DATA_TEST_SIZE); > > > >> + for (uint32_t i =3D 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > > > >> + test_buffer[i] =3D (uint8_t)(rand() % ((uint8_t)-1)) | = 1; > > > >> + > > > >> + test_buffer[BIG_DATA_TEST_SIZE-1] =3D 0; > > > >> + int_data.buf_idx =3D &i; > > > > > > > > >=20