[dpdk-dev] [PATCH] mk: fix examples build failure

[dpdk-dev] [PATCH] mk: fix examples build failure

[steeven lee]

1. Fix examples build failure
2. make build as default output folder name

Signed-off-by: steeven <steeven@gmail.com>
---
 mk/internal/rte.extvars.mk | 4 ++--
 mk/rte.extsubdir.mk        | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
index 040d39f..cabef0a 100644
--- a/mk/internal/rte.extvars.mk
+++ b/mk/internal/rte.extvars.mk
@@ -52,9 +52,9 @@ RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile
 export RTE_EXTMK

 # RTE_SDK_BIN must point to .config, include/ and lib/.
-RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)
+RTE_SDK_BIN := $(RTE_SDK)/build
 ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)
-$(error Cannot find .config in $(RTE_SDK))
+$(error Cannot find .config in $(RTE_SDK_BIN))
 endif

 #
diff --git a/mk/rte.extsubdir.mk b/mk/rte.extsubdir.mk
index f50f006..819020a 100644
--- a/mk/rte.extsubdir.mk
+++ b/mk/rte.extsubdir.mk
@@ -46,7 +46,7 @@ $(DIRS-y):
        @echo "== $@"
        $(Q)$(MAKE) -C $(@) \
                M=$(CURDIR)/$(@)/Makefile \
-               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/$(@)/$(RTE_TARGET) \
+               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/build \
                BASE_OUTPUT=$(BASE_OUTPUT) \
                CUR_SUBDIR=$(CUR_SUBDIR)/$(@) \
                S=$(CURDIR)/$(@) \
-- 
1.9.1

Re: [dpdk-dev] [PATCH] mk: fix examples build failure

[Thomas Monjalon]

2015-12-24 20:38, steeven lee:
> 1. Fix examples build failure

Please explain in the commit log what was the issue.

> 2. make build as default output folder name

It should be a separate patch.
What is the benefit?
Please give some example command lines.

Thanks

Re: [dpdk-dev] [PATCH] mk: fix examples build failure

[Qiu, Michael]

On 12/24/2015 8:38 PM, steeven lee wrote:
> 1. Fix examples build failure
> 2. make build as default output folder name
>
> Signed-off-by: steeven <steeven@gmail.com>
> ---
>  mk/internal/rte.extvars.mk | 4 ++--
>  mk/rte.extsubdir.mk        | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
> index 040d39f..cabef0a 100644
> --- a/mk/internal/rte.extvars.mk
> +++ b/mk/internal/rte.extvars.mk
> @@ -52,9 +52,9 @@ RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile
>  export RTE_EXTMK
>
>  # RTE_SDK_BIN must point to .config, include/ and lib/.
> -RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)
> +RTE_SDK_BIN := $(RTE_SDK)/build
>  ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)
> -$(error Cannot find .config in $(RTE_SDK))
> +$(error Cannot find .config in $(RTE_SDK_BIN))
>  endif
>
>  #
> diff --git a/mk/rte.extsubdir.mk b/mk/rte.extsubdir.mk
> index f50f006..819020a 100644
> --- a/mk/rte.extsubdir.mk
> +++ b/mk/rte.extsubdir.mk
> @@ -46,7 +46,7 @@ $(DIRS-y):
>         @echo "== $@"
>         $(Q)$(MAKE) -C $(@) \
>                 M=$(CURDIR)/$(@)/Makefile \
> -               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/$(@)/$(RTE_TARGET) \
> +               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/build \
>                 BASE_OUTPUT=$(BASE_OUTPUT) \
>                 CUR_SUBDIR=$(CUR_SUBDIR)/$(@) \
>                 S=$(CURDIR)/$(@) \

Could you show your compile error log? And how to reproduce it?

Thanks,
Michael

Re: [dpdk-dev] [PATCH] mk: fix examples build failure

[Yuanhan Liu]

On Thu, Dec 24, 2015 at 08:38:07PM +0800, steeven lee wrote:
> 1. Fix examples build failure

Paste the build error here, so that we know you are acutally fixing a
build error. And if it's a build error specific to some GCC, or Linux
distribution, please also note it in the commit log.

> 2. make build as default output folder name

No, please do not do two things in one patch.

	--yliu
> 
> Signed-off-by: steeven <steeven@gmail.com>
> ---
>  mk/internal/rte.extvars.mk | 4 ++--
>  mk/rte.extsubdir.mk        | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
> index 040d39f..cabef0a 100644
> --- a/mk/internal/rte.extvars.mk
> +++ b/mk/internal/rte.extvars.mk
> @@ -52,9 +52,9 @@ RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile
>  export RTE_EXTMK
> 
>  # RTE_SDK_BIN must point to .config, include/ and lib/.
> -RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)
> +RTE_SDK_BIN := $(RTE_SDK)/build
>  ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)
> -$(error Cannot find .config in $(RTE_SDK))
> +$(error Cannot find .config in $(RTE_SDK_BIN))
>  endif
> 
>  #
> diff --git a/mk/rte.extsubdir.mk b/mk/rte.extsubdir.mk
> index f50f006..819020a 100644
> --- a/mk/rte.extsubdir.mk
> +++ b/mk/rte.extsubdir.mk
> @@ -46,7 +46,7 @@ $(DIRS-y):
>         @echo "== $@"
>         $(Q)$(MAKE) -C $(@) \
>                 M=$(CURDIR)/$(@)/Makefile \
> -               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/$(@)/$(RTE_TARGET) \
> +               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/build \
>                 BASE_OUTPUT=$(BASE_OUTPUT) \
>                 CUR_SUBDIR=$(CUR_SUBDIR)/$(@) \
>                 S=$(CURDIR)/$(@) \
> -- 
> 1.9.1

Re: [dpdk-dev] [PATCH] mk: fix examples build failure

[steeven lee]

Hi Michael:

Seems the examples makefile seems to be broken, easy to reproduce on
master branch, below is the outputs on Ubuntu 14.04 amd64 version:

~/work/dpdk$ export RTE_SDK=/home/steeven/work/dpdk
~/work/dpdk$ cd /home/steeven/work/dpdk/examples/helloworld/
~/work/dpdk/examples/helloworld$ export RTE_TARGET=x86_64-native-linuxapp-gcc
~/work/dpdk/examples/helloworld$ make
/home/steeven/work/dpdk/mk/internal/rte.extvars.mk:57: *** Cannot find
.config in /home/xueming/work/dpdk.  Stop.
~/work/dpdk/examples/helloworld$ cd ../cmdline/
~/work/dpdk/examples/cmdline$ make
/home/steeven/work/dpdk/mk/internal/rte.extvars.mk:57: *** Cannot find
.config in /home/xueming/work/dpdk.  Stop.


Thanks,
Steeven

On Mon, Dec 28, 2015 at 12:20 PM, Qiu, Michael <michael.qiu@intel.com> wrote:
> On 12/24/2015 8:38 PM, steeven lee wrote:
>> 1. Fix examples build failure
>> 2. make build as default output folder name
>>
>> Signed-off-by: steeven <steeven@gmail.com>
>> ---
>>  mk/internal/rte.extvars.mk | 4 ++--
>>  mk/rte.extsubdir.mk        | 2 +-
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
>> index 040d39f..cabef0a 100644
>> --- a/mk/internal/rte.extvars.mk
>> +++ b/mk/internal/rte.extvars.mk
>> @@ -52,9 +52,9 @@ RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile
>>  export RTE_EXTMK
>>
>>  # RTE_SDK_BIN must point to .config, include/ and lib/.
>> -RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)
>> +RTE_SDK_BIN := $(RTE_SDK)/build
>>  ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)
>> -$(error Cannot find .config in $(RTE_SDK))
>> +$(error Cannot find .config in $(RTE_SDK_BIN))
>>  endif
>>
>>  #
>> diff --git a/mk/rte.extsubdir.mk b/mk/rte.extsubdir.mk
>> index f50f006..819020a 100644
>> --- a/mk/rte.extsubdir.mk
>> +++ b/mk/rte.extsubdir.mk
>> @@ -46,7 +46,7 @@ $(DIRS-y):
>>         @echo "== $@"
>>         $(Q)$(MAKE) -C $(@) \
>>                 M=$(CURDIR)/$(@)/Makefile \
>> -               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/$(@)/$(RTE_TARGET) \
>> +               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/build \
>>                 BASE_OUTPUT=$(BASE_OUTPUT) \
>>                 CUR_SUBDIR=$(CUR_SUBDIR)/$(@) \
>>                 S=$(CURDIR)/$(@) \
>
> Could you show your compile error log? And how to reproduce it?
>
> Thanks,
> Michael

Re: [dpdk-dev] [PATCH] mk: fix examples build failure

[Thomas Monjalon]

Hi,

2015-12-24 20:38, steeven lee:
> --- a/mk/internal/rte.extvars.mk
> +++ b/mk/internal/rte.extvars.mk
>  # RTE_SDK_BIN must point to .config, include/ and lib/.
> -RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)
> +RTE_SDK_BIN := $(RTE_SDK)/build

RTE_TARGET is the right value here.
To make it work with "build/" please use RTE_TARGET=build when
building your example.

>  ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)
> -$(error Cannot find .config in $(RTE_SDK))
> +$(error Cannot find .config in $(RTE_SDK_BIN))
>  endif

Yes you're right, the error message looks wrong.
Please, could you send a v2 patch for this fix?

> --- a/mk/rte.extsubdir.mk
> +++ b/mk/rte.extsubdir.mk
> @@ -46,7 +46,7 @@ $(DIRS-y):
>         @echo "== $@"
>         $(Q)$(MAKE) -C $(@) \
>                 M=$(CURDIR)/$(@)/Makefile \
> -               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/$(@)/$(RTE_TARGET) \
> +               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/build \
>                 BASE_OUTPUT=$(BASE_OUTPUT) \
>                 CUR_SUBDIR=$(CUR_SUBDIR)/$(@) \
>                 S=$(CURDIR)/$(@) \

I think this change is not needed.
Probably your command is incorrect. Please paste them here.
If the doc is incomplete, a patch would also be welcome. Thanks

[dpdk-dev] [PATCH] mk: fix error message

[Thomas Monjalon]

When specifying a wrong directory with RTE_SDK and RTE_TARGET
to build an application, the error message about missing config
file was wrong.

Fixes: 6b62a72a70d0 ("mk: install a standard cutomizable tree")

Reported-by: Steeven Lee <steeven@gmail.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 mk/internal/rte.extvars.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
index 040d39f..e2462fd 100644
--- a/mk/internal/rte.extvars.mk
+++ b/mk/internal/rte.extvars.mk
@@ -54,7 +54,7 @@ export RTE_EXTMK
 # RTE_SDK_BIN must point to .config, include/ and lib/.
 RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)
 ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)
-$(error Cannot find .config in $(RTE_SDK))
+$(error Cannot find .config in $(RTE_SDK_BIN))
 endif
 
 #
-- 
2.7.0

Re: [dpdk-dev] [PATCH] mk: fix error message

[Thomas Monjalon]

2016-03-02 16:52, Thomas Monjalon:
> When specifying a wrong directory with RTE_SDK and RTE_TARGET
> to build an application, the error message about missing config
> file was wrong.
> 
> Fixes: 6b62a72a70d0 ("mk: install a standard cutomizable tree")
> 
> Reported-by: Steeven Lee <steeven@gmail.com>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied