From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 78666C338
 for <dev@dpdk.org>; Fri,  5 Jun 2015 22:45:59 +0200 (CEST)
Received: by wifx6 with SMTP id x6so31969853wif.0
 for <dev@dpdk.org>; Fri, 05 Jun 2015 13:45:58 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=HaP2IL9UoYNCXSL1Xu8MyhM7UGLXb78ss8Kf+taLBDg=;
 b=EDpWeZN8/LK1CXLug8GZuJcMTy0O2W7H4EOsaFwEWFPA4M+C5iOGJDZeQ9txJfFMsC
 DNl4gom3+swMpg6KXpyoRU89Y50CaS9wALkVU7WGwX1M0bcnck9chYrHgfM4741mbWv9
 ig4Np+1tLy6HtAzgf2JIJ3LmJijUkvC4BW5NYEVphpu1jfgzZZEvgUqYt2GYeZlMMygq
 /+bh7uOgSuzXjMwz7CGPyBBHsKGKV/zQOibccfvsu6lQv/jxlFqogqPFnNbGcnxg/wVt
 TE9EiiCQJL6F8RPkQtweH6lH/q4QgqnOaySCRB3GTOghF2nmW5ZfsnEvrtV5/Ey8koty
 fltQ==
X-Gm-Message-State: ALoCoQkGnyXfUXwqQfvKk7w6SaTp/+un8PJY4nGD3a6Wt4Hps6aZdLZGXUlpDHi8VyvJCpLhGchT
X-Received: by 10.180.108.201 with SMTP id hm9mr163804wib.5.1433537157842;
 Fri, 05 Jun 2015 13:45:57 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id v3sm5006832wiz.14.2015.06.05.13.45.55
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 05 Jun 2015 13:45:56 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Date: Fri, 05 Jun 2015 22:45:04 +0200
Message-ID: <19910784.6F5piXXB0d@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1433520077-11234-1-git-send-email-bruce.richardson@intel.com>
References: <1433520077-11234-1-git-send-email-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] examples/distributor: fix missing ";
	" in debug macro
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jun 2015 20:45:59 -0000

2015-06-05 17:01, Bruce Richardson:
> The macro to turn on additional debug output when the app was compiled
> with "-DDEBUG" was missing a ";".

It shows that such dead code is almost never tested.
It would be saner if this command would return no result:
	git grep 'ifdef.*DEBUG' examples
		examples/distributor/main.c:#ifdef DEBUG
		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
		examples/packet_ordering/main.c:#ifdef DEBUG
		examples/vhost/main.c:#ifdef DEBUG
		examples/vhost/main.h:#ifdef DEBUG
		examples/vhost_xen/main.c:#ifdef DEBUG
		examples/vhost_xen/main.h:#ifdef DEBUG

There is no good reason to not use CONFIG_RTE_LOG_LEVEL to trigger debug build.