From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47DA4A0562; Thu, 15 Apr 2021 00:58:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5059161D9F; Thu, 15 Apr 2021 00:58:17 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 9F1B8161D9B for ; Thu, 15 Apr 2021 00:58:16 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 1B9C21347; Wed, 14 Apr 2021 18:58:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Apr 2021 18:58:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 2fgJ2m7Qc4D48f/dJoIlVddrbRA98gqSZ7GDIPQ2BVA=; b=HXLGJOrbX8Hyj+8T D+Yiz02YSEQDfPc4of3oE13dLsoVDYVj4BWFhBOMxU/ljcxtyHE6ehqF96iqVQLN 0n30qYqb7I1Vnqf8OYqow3IqpcfbQ9dhEQ6zgzXrkb5eYFYnsLSmPOARX/DcgVbE B2tVrPCuzXksuYDcQU6DqH5uaMaditMGlzNxlq7S1Y5BNaBF0vaafNIW+rHo1GGG FtBu5tp1C9JJMzik5fZZLILhqPIb2ImPEwwid1YQH8v+oOeGy4wu8Z1uz5z8byWs XNB16HOTvR+CZ9eS5+BaVZoTACdCocsUEeztKcv5XbwUNERUXLGwGkJf8nikY6gx /Vtz0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=2fgJ2m7Qc4D48f/dJoIlVddrbRA98gqSZ7GDIPQ2B VA=; b=f1qi1dyEKKCjTmQ4VKttjoWRq9LCuNy9hwQdIdnaQUDTkFNN7OD+HrdIV bwVX5iDBm1E/eHtHGL2awGJ3GgDfkWvmG3pu7XktpiIOa7DQiXwtGkkY+2tm4FFf Ylgasr6skxW9jeR12vmqyU1+EClIof4g4yWBQOBfvcmKyLqjcSaTxkcOtvx8EhfK jFbypAG2yCYAShRPBCn7gUGEnyKvlUtPSLcrZnn4386GRu7D5vvRShwdax2khOCx 1w+vxzabQssCVgSxPEqNwqGllBA16Zqn+p3hCkssAruNnXdgAJDIaARmc93G8dv5 8+jES1uJQ1NTH1IinJP63XFxAvR5w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelvddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A7F93108005C; Wed, 14 Apr 2021 18:58:13 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: Ranjit Menon , dev@dpdk.org Date: Thu, 15 Apr 2021 00:58:09 +0200 Message-ID: <1991894.Om3ic19byZ@thomas> In-Reply-To: <20210415010808.0d33a835@sovereign> References: <20210407222249.6729-1-dmitry.kozliuk@gmail.com> <7340b084-cca7-88da-8656-dafa4348cfc0@intel.com> <20210415010808.0d33a835@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/04/2021 00:08, Dmitry Kozlyuk: > 2021-04-14 14:47 (UTC-0700), Ranjit Menon: > > On 4/14/2021 2:42 PM, Thomas Monjalon wrote: > > > 14/04/2021 23:34, Ranjit Menon: > > >> On 4/14/2021 2:12 PM, Thomas Monjalon wrote: > > >>> 13/04/2021 09:00, Dmitry Kozlyuk: > > >>>> Hi Ranjit, > > >>>> > > >>>> 2021-04-12 21:46 (UTC-0700), Ranjit Menon: > > >>>> [...] > > >>>>> The change to remove the networking shim breaks l2fwd compilation on > > >>>>> Windows, since l2fwd/main.c includes netinet/in.h explicitly. > > >>>>> > > >>>>> How do you propose we fix this, only for Windows? > > >>>> This include is redundant for this file on all platforms, it can be removed. > > >>>> Since -Dexamples=all doesn't work on Windows because of missing dependencies, > > >>>> I wonder which of them need fixing. > > >>> Let's fix the examples which are supported on Windows. > > >>> Other examples may require more updates anyway. > > >>> > > >> Thanks, Thomas. For now, this is only required in l2fwd. > > > Only l2fwd is supported on Windows? > > > > > >> Dmitry, can you please include this in your patch 4/4? > > > Ranjit, if you tell me what exactly is needed, I can do it > > > and merge the series quickly. > > I've just sent v10 with all required fixes. Thank you Some acks were removed from this v10, I am re-adding them. > > Sure, Thomas. In l2wfd/main.c, all we need to do is remove the #include > > line. > > > > This include file will not exist on Windows anymore, and Dmitry > > determined that this include is not required in l2fwd on all platforms. > > For the reference, complete list of examples that can build for Windows: > > helloworld > cmdline > flow_filtering > ipv4_multicast > l2fwd > link_status_interrupt > qos_meter > rxtx_callbacks (-Wformat with clang) > service_cores > skeleton devtools/test-meson-builds.sh should be updated to compile these examples with MinGW.