From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D88184C8E for ; Sun, 18 Nov 2018 13:41:43 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6503A21B74; Sun, 18 Nov 2018 07:41:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 18 Nov 2018 07:41:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PjNOCLPCj4hCohDh0MXsVWWA+t9+4/xjLoChQpCkB8k=; b=MYeCFgM2oQvH lwzeuaWUPX7L/0W0WbZW3oKpEEMacJxhfLWnP9ZnkbKTiN2/2oyF/23msG9KcmMk c6g+Apzq7245ZTPm3Ax8fM8WqRksb6aA0JKb/bwvtC/qsrYrWEFsKS6b/GyfqvhD w4mC0zzu3BWDAr9xnmWayW6J3VYbgk4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=PjNOCLPCj4hCohDh0MXsVWWA+t9+4/xjLoChQpCkB 8k=; b=Yjx+P/b8or3I22GKdPZuRUbBI521RLT3TT66l+UXvM1/of7Db3+fpXLx5 akHu7fHG2TolqKjR/p568Rmwt5/0POBGTsl7/nhobN5JUk1hl7r3rJ6hspgAGWaz yUVC9rqWktk2GgBVDq3Wkgs6qB26zY0Um0NHuhqvZJWKPsSx8duIVO6mYoyzfukM UpeH0L5DtFbL3LIYE9lbEYNYTzFvqBrZF/u2df6A1FWylOb/RPVSrAx+nY6VJO2m KNIln+1w5CO+FHa5ByuXRI1+z5wQ1lqMS84tw81scq11zbrKSGeTAUJW8U4V7nye Fs8ddrn8ICb34YE1+B9etW9Y0wWgA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7B1BE102F0; Sun, 18 Nov 2018 07:41:42 -0500 (EST) From: Thomas Monjalon To: Kevin Laatz Cc: dev@dpdk.org, "Burakov, Anatoly" Date: Sun, 18 Nov 2018 13:41:38 +0100 Message-ID: <1994389.ETnpRDjGGD@xps> In-Reply-To: References: <20181114112005.16378-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: fix duplicate function declaration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2018 12:41:44 -0000 14/11/2018 12:24, Burakov, Anatoly: > On 14-Nov-18 11:20 AM, Kevin Laatz wrote: > > The rte_eal_get_runtime_dir() function is currently being declared in two > > header files. > > > > This API was made public in commit 6911c9fd8fbe ("eal: export function to > > get runtime directory"), adding it to rte_eal.h. To make it public, the > > 'rte' prefix was added to the function so it needed to be modified in the > > original location of the declaration, eal_filesystem.h. By only modifying, > > and not removing the decalration, it is now a duplicate. > > > > This patch removes the declaration from eal_filesystem.h. > > > > Fixes: 6911c9fd8fbe ("eal: export function to get runtime directory") > > > > Reported-by: Anatoly Burakov > > Signed-off-by: Kevin Laatz > > > > --- > > v2: > > - Fix commit message (checkpatch warning) > > --- > > I was too late to ack the first one... > > Acked-by: Anatoly Burakov Applied, thanks