From: Ferruh Yigit <ferruh.yigit@intel.com> To: Andrew Rybchenko <arybchenko@solarflare.com>, Harry van Haaren <harry.van.haaren@intel.com>, Ori Kam <orika@nvidia.com>, Bruce Richardson <bruce.richardson@intel.com>, Radu Nicolau <radu.nicolau@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>, Sunil Kumar Kori <skori@marvell.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>, Jerin Jacob <jerinj@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, David Hunt <david.hunt@intel.com> Cc: dev@dpdk.org, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru> Subject: Re: [dpdk-dev] [PATCH 04/11] examples: check eth dev stop status Date: Wed, 14 Oct 2020 18:38:34 +0100 Message-ID: <1995dedd-d09c-c165-54f4-20d9830bc109@intel.com> (raw) In-Reply-To: <1602682146-4722-5-git-send-email-arybchenko@solarflare.com> On 10/14/2020 2:28 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru> > > rte_eth_dev_stop() return value was changed from void to int, > so this patch modify usage of this function across examples > according to new return type. > > Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru> > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> <...> > diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c > index 7e3078788e..8d6c7ec237 100644 > --- a/examples/l2fwd/main.c > +++ b/examples/l2fwd/main.c > @@ -896,7 +896,10 @@ main(int argc, char **argv) > if ((l2fwd_enabled_port_mask & (1 << portid)) == 0) > continue; > printf("Closing port %d...", portid); > - rte_eth_dev_stop(portid); > + ret = rte_eth_dev_stop(portid); > + if (ret != 0) > + rte_exit(EXIT_FAILURE, "rte_eth_dev_stop: err=%d, port=%d\n", > + ret, portid); Same comment here, not sure if exiting on stop error and break freeing resources is better thing to do? Overall, for the whole set, unless the focus is in the 'stop', like testing it, what do you think log the error and ignore it?
next prev parent reply other threads:[~2020-10-14 17:39 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-14 13:28 [dpdk-dev] [PATCH 00/11] ethdev: change device stop to return status Andrew Rybchenko 2020-10-14 13:28 ` [dpdk-dev] [PATCH 01/11] ethdev: change eth dev stop function to return int Andrew Rybchenko 2020-10-14 13:33 ` Thomas Monjalon 2020-10-14 13:40 ` Andrew Rybchenko 2020-10-14 17:29 ` Ferruh Yigit 2020-10-14 13:28 ` [dpdk-dev] [PATCH 02/11] test/event: check eth dev stop status Andrew Rybchenko 2020-10-14 13:28 ` [dpdk-dev] [PATCH 03/11] app: " Andrew Rybchenko 2020-10-14 17:34 ` Ferruh Yigit 2020-10-14 13:28 ` [dpdk-dev] [PATCH 04/11] examples: " Andrew Rybchenko 2020-10-14 17:38 ` Ferruh Yigit [this message] 2020-10-14 13:29 ` [dpdk-dev] [PATCH 05/11] net/bonding: " Andrew Rybchenko 2020-10-14 17:45 ` Ferruh Yigit 2020-10-14 13:29 ` [dpdk-dev] [PATCH 06/11] kni: " Andrew Rybchenko 2020-10-14 13:29 ` [dpdk-dev] [PATCH 07/11] test/bonding: " Andrew Rybchenko 2020-10-14 13:29 ` [dpdk-dev] [PATCH 08/11] app/flow-perf: " Andrew Rybchenko 2020-10-15 8:04 ` Wisam Monther 2020-10-14 13:29 ` [dpdk-dev] [PATCH 09/11] app/testpmd: " Andrew Rybchenko 2020-10-14 13:29 ` [dpdk-dev] [PATCH 10/11] net/failsafe: " Andrew Rybchenko 2020-10-15 10:37 ` [dpdk-dev] [PATCH v2] " Gaetan Rivet 2020-10-14 13:29 ` [dpdk-dev] [PATCH 11/11] ethdev: change stop device callback to return int Andrew Rybchenko 2020-10-14 18:08 ` Ferruh Yigit 2020-10-15 10:40 ` Gaëtan Rivet 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 00/11] ethdev: change device stop to return status Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 01/11] ethdev: change eth dev stop function to return int Andrew Rybchenko 2020-10-16 9:22 ` Ferruh Yigit 2020-10-16 11:20 ` Kinsella, Ray 2020-10-16 17:13 ` Andrew Rybchenko 2020-10-19 9:37 ` Kinsella, Ray 2020-10-16 16:20 ` Ferruh Yigit 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 02/11] test/event: check eth dev stop status Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 03/11] app: " Andrew Rybchenko 2020-10-16 1:28 ` Min Hu (Connor) 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 04/11] examples: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 05/11] net/bonding: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 06/11] kni: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 07/11] test/bonding: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 08/11] app/flow-perf: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 09/11] app/testpmd: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 10/11] net/failsafe: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 11/11] ethdev: change stop device callback to return int Andrew Rybchenko 2020-10-16 18:37 ` Ferruh Yigit 2020-10-18 8:55 ` Xu, Rosen 2020-10-16 18:54 ` [dpdk-dev] [PATCH v2 00/11] ethdev: change device stop to return status Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1995dedd-d09c-c165-54f4-20d9830bc109@intel.com \ --to=ferruh.yigit@intel.com \ --cc=Ivan.Ilchenko@oktetlabs.ru \ --cc=akhil.goyal@nxp.com \ --cc=arybchenko@solarflare.com \ --cc=bruce.richardson@intel.com \ --cc=david.hunt@intel.com \ --cc=dev@dpdk.org \ --cc=harry.van.haaren@intel.com \ --cc=jerinj@marvell.com \ --cc=kirankumark@marvell.com \ --cc=ndabilpuram@marvell.com \ --cc=orika@nvidia.com \ --cc=pbhagavatula@marvell.com \ --cc=radu.nicolau@intel.com \ --cc=skori@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git