From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 3F547C44C for ; Mon, 27 Apr 2015 19:17:19 +0200 (CEST) Received: by wgin8 with SMTP id n8so123405716wgi.0 for ; Mon, 27 Apr 2015 10:17:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=2ImsCWn/+E5wUdY5k2f1YEFqdkqdZS4NrI3JtSnFtS0=; b=ITNdJfVqxDpRE+gnx2TupC0BFB3tAjmWlA954fv/vRgSCNCZVBpPbT7e/ep3qdb9aE WVHZosLczAZmGAdUW3VZusWHxj5w1j3LXZM0t9zDCDOZ/8hRLlrMHpbLWcVvRYj4tiYq DO5DaomiOrfB+QA3lfrJQI18FhLTIA75IOu3nBsDygfmrROg617XCsn/n96ZC77lRSkn yW1efKA7An7Xm5vgtDMbF1XV7wlAEachA1L74FQ4nnBmiQ1aEVDhn/mK063eRrfA8qLR QWeSzKw7tcQun3IF1n/XP3dAHmCIMG3wNwgE9s7vuaCfIuep7EQG4FRGsHctneaTr2TE 4WRg== X-Gm-Message-State: ALoCoQkMSPO55IQ9auXdHMr/foMJW9H1S54HQJ3Cs6NmhKVdBk+kUvX4M0aQbl3F8kfNhT3KSuk4 X-Received: by 10.194.92.137 with SMTP id cm9mr24696967wjb.133.1430155038992; Mon, 27 Apr 2015 10:17:18 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id z12sm30281398wjw.39.2015.04.27.10.17.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2015 10:17:17 -0700 (PDT) From: Thomas Monjalon To: Helin Zhang Date: Mon, 27 Apr 2015 19:16:35 +0200 Message-ID: <1998049.eU2MTJspAg@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1429518150-28098-4-git-send-email-helin.zhang@intel.com> References: <1429518150-28098-1-git-send-email-helin.zhang@intel.com> <1429518150-28098-4-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, steven.j.murray@intel.com, chiu-pi.shih@intel.com, monica.kenguva@intel.com Subject: Re: [dpdk-dev] [PATCH 03/18] i40e: adjustment of register definitions and relevant X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Apr 2015 17:17:19 -0000 2015-04-20 16:22, Helin Zhang: > More register definitions and their relevant masks are added > publically. Also few useless macros are deleted. > > Signed-off-by: Helin Zhang > --- > lib/librte_pmd_i40e/i40e/i40e_register.h | 1981 +++++++++++++++++++++++++++++- All these values are not used in the driver, right? > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > @@ -1269,9 +1269,6 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > I40E_GLPRT_BPTCL(hw->port), > pf->offset_loaded, &os->eth.tx_broadcast, > &ns->eth.tx_broadcast); > - i40e_stat_update_32(hw, I40E_GLPRT_TDPC(hw->port), > - pf->offset_loaded, &os->eth.tx_discards, > - &ns->eth.tx_discards); The relation between this deletion and the rest of the patch is weird.