From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Tal Shnaiderman <talshn@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
"navasile@linux.microsoft.com" <navasile@linux.microsoft.com>,
"dmitrym@microsoft.com" <dmitrym@microsoft.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"lucp.at.work@gmail.com" <lucp.at.work@gmail.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values
Date: Mon, 12 Apr 2021 10:25:35 +0200 [thread overview]
Message-ID: <1998989.grVXzi9dvb@thomas> (raw)
In-Reply-To: <DM6PR12MB3945DF27B2FB8A2D2A0CD604A4709@DM6PR12MB3945.namprd12.prod.outlook.com>
12/04/2021 09:59, Tal Shnaiderman:
> > Subject: Re: [PATCH] eal/windows: fix pthreads macros return values
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Hi Tal,
> >
> > Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0:
> >
> > ../../../lib/librte_eal/common/eal_common_thread.c: In function
> > ‘ctrl_params_free’:
> > ../../../lib/librte_eal/windows/include/pthread.h:42:2: warning: value
> > computed is not used [-Wunused-value]
> > 42 | !DeleteSynchronizationBarrier(barrier)
> >
> > Probably applies to other functions and may fire in combination with future
> > backported patches. Hopefully since 21.05 there will be new threading API.
>
> Thanks Dmitry, it's odd that the compiler complains only now, I'd expect to see this warning even before the change.
>
> Do we know if the new threading API will be in 21.05? API changes close in 3 days and I didn't see it get reviewed/acked.
Yes it seems too short for 21.05.
> I can change only pthread_barrier_init for now, since currently without this change Windows runtime is broken, what do you think?
next prev parent reply other threads:[~2021-04-12 8:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 19:54 Tal Shnaiderman
2021-04-11 21:00 ` Dmitry Kozlyuk
2021-04-12 7:59 ` Tal Shnaiderman
2021-04-12 8:25 ` Thomas Monjalon [this message]
2021-04-12 10:03 ` Dmitry Kozlyuk
2021-04-12 10:07 ` David Marchand
2021-04-12 10:26 ` Tal Shnaiderman
2021-04-12 10:37 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
2021-04-12 20:38 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1998989.grVXzi9dvb@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=lucp.at.work@gmail.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=stable@dpdk.org \
--cc=talshn@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).